Define GIT_SSH_MEMORY_CREDENTIALS for libgit2#763
Closed
daxelrod wants to merge 1 commit intonodegit:masterfrom
Closed
Define GIT_SSH_MEMORY_CREDENTIALS for libgit2#763daxelrod wants to merge 1 commit intonodegit:masterfrom
daxelrod wants to merge 1 commit intonodegit:masterfrom
Conversation
Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow sshKeyMemoryNew to work. Fixes nodegit#760
Contributor
Author
|
I guess I'll have to do more digging to find out why Windows doesn't like this define. Any insight would be appreciated. |
Collaborator
|
It looks like libssh2 needs an update. That function isn't in the current implementation in |
Collaborator
|
Bumped to the latest libssh2 in #830, once that lands (if lol), this can be rebased to see if that fixes it. |
a78275a to
206d27d
Compare
Collaborator
|
#1071 is merged, let's do this up guyz |
Collaborator
|
Fixed here: #949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.
Fixes #760