8000 Fix CI failures on node 0.12 by srajko · Pull Request #1144 · nodegit/nodegit · GitHub
[go: up one dir, main page]

Skip to content

Fix CI failures on node 0.12#1144

Merged
johnhaley81 merged 1 commit intonodegit:masterfrom
srajko:fix-travis-failure
Oct 7, 2016
Merged

Fix CI failures on node 0.12#1144
johnhaley81 merged 1 commit intonodegit:masterfrom
srajko:fix-travis-failure

Conversation

@srajko
Copy link
Collaborator
@srajko srajko commented Oct 4, 2016

No description provided.

@srajko srajko force-pushed the fix-travis-failure branch 4 times, most recently from 520825f to 4ca15bf Compare October 5, 2016 16:46
@srajko
Copy link
Collaborator Author
srajko commented Oct 5, 2016

The failure with node 0.12 was happening after npm install, but it doesn't look like the failure was critical to the rest of the build. The fix I converged on ignores the npm install failure for node 0.12 (see comments in the yml file). If this is acceptable, I can squash this down to merge.

@srajko srajko force-pushed the fix-travis-failure branch 2 times, most recently from 36b9eaa to 68bab90 Compare October 5, 2016 20:23
Revert "Use npm 2.15.11 with node 0.12"

This reverts commit 9503b5c.
Revert "Log npm-debug.log after failure"

This reverts commit 412ce63.
Remove ls attempt


Ls purported npm-debug.log location and ignore npm install failure


Attempt to cat npm-debug.log after install failure


Log npm-debug.log after failure


Use npm 2.15.11 with node 0.12
@srajko srajko force-pushed the fix-travis-failure branch from 68bab90 to 8d69ff2 Compare October 5, 2016 21:43
@srajko srajko changed the title [WIP] Trying to fix CI failures Trying to fix CI failures Oct 5, 2016
@srajko srajko changed the title Trying to fix CI failures Fix CI failures on node 0.12 Oct 5, 2016
@johnhaley81
Copy link
Collaborator

This looks good to me. We're going to stop supporting 0.12 in December anyways since that's it's EOL but this will let us get to that mark at least.

@johnhaley81 johnhaley81 merged commit 9f2f1ba into nodegit:master Oct 7, 2016
@johnhaley81 johnhaley81 deleted the fix-travis-failure branch October 7, 2016 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0