8000 Fix CI failures on node 0.12 by srajko · Pull Request #1144 · nodegit/nodegit · GitHub
[go: up one dir, main page]
Skip to content

Fix CI failures on node 0.12 #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 1 commit into from
Oct 7, 2016
Merged

Fix CI failures on node 0.12 #1144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,19 @@ before_install:
export JOBS=4;
fi

# node 0.12 is sometimes failing
# with a "Callback called more than once" error
# Despite that error, it seems like modules do get installed correctly,
# and the rest of the build proceeds as normal.
# So we ignore that error, just for node 0.12
# If npm install ever fails in a more significant way,
# the rest of the build should hopefully fail anyway.
install:
- npm install
- if [[ $NODE_VERSION == "0.12" ]]; then
npm install || true;
else
npm install;
fi

# This is a random private key used purely for testing.
before_script:
Expand Down
0