8000 Make Ignore.pathIsIgnored async by joshaber · Pull Request #970 · nodegit/nodegit · GitHub
[go: up one dir, main page]
Skip to content

Make Ignore.pathIsIgnored async #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnhaley81 merged 2 commits into from
Mar 28, 2016
Merged

Make Ignore.pathIsIgnored async #970

johnhaley81 merged 2 commits into from
Mar 28, 2016

Conversation

@joshaber
Copy link
Collaborator
@joshaber joshaber commented Mar 25, 2016

Since it’s potentially doing IO and touching global state, it should be async.

@joshaber joshaber mentioned this pull request Mar 25, 2016
Merged
2 tasks
nathansobo
nathansobo reviewed Mar 25, 2016
View reviewed changes
generate/input/descriptor.json
}
}
},
"isAsync": true
Copy link
@nathansobo nathansobo Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it's pretty cool that this is all it took.

Copy link
Collaborator Author
@joshaber joshaber Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 👶

Copy link
@nathansobo nathansobo Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd this baby come from!? Now I gotta take care of it.

Copy link
Member
@tbranyen tbranyen Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        🎉                                   🎉
    🎉 yeah, it's pretty cool        🎉
       🎉                 🎉
     🎉;     🎉
🐧

@johnhaley81
Copy link
Collaborator
johnhaley81 commented Mar 25, 2016

image

lol

@joshaber
Copy link
Collaborator Author
joshaber commented Mar 28, 2016

This should be ready to merge AFAIK.

@johnhaley81
Copy link
Collaborator
johnhaley81 commented Mar 28, 2016

LGTM. Thanks @joshaber

@johnhaley81 johnhaley81 merged commit a32265c into master Mar 28, 2016
@johnhaley81 johnhaley81 deleted the async-path-is-ignored branch March 28, 2016 17:48
@johnhaley81 johnhaley81 removed the ready label Mar 28, 2016
@joshaber
Copy link
Collaborator Author
joshaber commented Mar 28, 2016

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshaber @johnhaley81 @nathanso 3380 bo @tbranyen
0