extmod/modbluetooth: Addressing modes, Unix H4 UART, reliability fixes #6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the HCI UART to use a non-heap mp_irq_obj_t, which avoids needing to make a root pointer for it. Misc cleanups to mpirq.c to remove unused functionality.
Also use correct format specifier for %zu. Always prefix with "btstack:" or "nimble:".
Previously the interaction between the different parts was different on each port and each stack. This commit defines common interfaces between them and implements them for cyw43, btstack, nimble, stm32, unix.
Generally a controller should either have its own public address hardcoded, or loaded by the driver (e.g. cywbt43). However, for a controller that has no public address where you still want a long-term stable address, this allows you to use a static address generated by the port. Typically on STM32 this will be an LAA, but a board might override this.
2ms used previously was not long enough and the result is that it loses HCI sync. Also print error on tx failure to make this more obvious in the future.
andrewleech
reviewed
Aug 18, 2020
ports/unix/mphciport.c
Outdated
| int flags = O_RDWR | O_NOCTTY | O_NONBLOCK; | ||
| uart_fd = open(uart_device_name, flags); | ||
| if (uart_fd == -1) { | ||
| DEBUG_printf("Unable to open port %s", uart_device_name); |
There was a problem hiding this comment.
This would be better as an exception that's then user visible - currently if the port is missing or cannot be opened it's a silent fail here and the rest of the startup just looks broken
There was a problem hiding this comment.
Done -- and added the plumbing to make this work for btstack and nimble. On btstack it can detect the init failure, on nimble it now leads to an init timeout.
andrewleech
reviewed
Aug 18, 2020
| uart_tx_data(&mp_bluetooth_hci_uart_obj, (void *)buf, len, &errcode); | ||
| if (errcode != 0) { | ||
| printf("\nmp_bluetooth_hci_uart_write: failed to write to UART %d\n", errcode); | ||
| } |
There was a problem hiding this comment.
In my branch I've changed this if to assert(errcode == 0);
My updated commit is here, it includes your comment and removes the extra comment/printf below:
andrewleech@32bf807
There was a problem hiding this comment.
I think this is too important to be a debug-only notification...
There was a problem hiding this comment.
Ah yeah, I forgot that asserts are disabled in non-debug builds... yep perhaps a static flag that can be checked at a higher layer will be needed, perhaps something that can then trigger a stack/hci reset.
MP and NimBLE must be on the same core (for synchronisation of the BLE ringbuf and the MP scheduler). However, in the current IDF versions (3.3 and 4.0) there are issues (e.g. micropython#6343) with running NimBLE on core 1. This change makes it possible to reliably run the BLE multitests.
4a6a5a8 to
6546f70
Compare
This allows `ble.active(1)` to fail correctly if the HCI controller is unavailable. Also avoids an infine loop in the NimBLE event handler where NimBLE doesn't correctly detect that the HCI controller is unavailable and keeps trying to reset. Also fixes an issue where GATT service registrations were left allocated, which led to a bad realloc if the stack was activated multiple times.
This was referenced Aug 20, 2020
This was referenced Aug 20, 2020
|
The following commits from this PR have been applied to master (they are minor and fix existing bugs) (the hash refers to the commit in master): |
jimmo
added a commit
to jimmo/micropython
that referenced
this pull request
Sep 1, 2020
MP and NimBLE must be on the same core (for synchronisation of the BLE ringbuf and the MP scheduler). However, in the current IDF versions (3.3 and 4.0) there are issues (e.g. micropython#6343) with running NimBLE on core 1. This change makes it possible to reliably run the BLE multitests.
dpgeorge
pushed a commit
to dpgeorge/micropython
that referenced
this pull request
Sep 4, 2020
MP and NimBLE must be on the same core (for synchronisation of the BLE ringbuf and the MP scheduler). However, in the current IDF versions (3.3 and 4.0) there are issues (e.g. micropython#6343) with running NimBLE on core 1. This change makes it possible to reliably run the BLE multitests.
|
Superseded by #6405 (with some notes there about what was not included). |
jimmo
added a commit
to jimmo/micropython
that referenced
this pull request
Sep 4, 2020
MP and NimBLE must be on the same core (for synchronisation of the BLE ringbuf and the MP schedul 5D39 er). However, in the current IDF versions (3.3 and 4.0) there are issues (e.g. micropython#6343) with running NimBLE on core 1. This change makes it possible to reliably run the BLE multitests.
jimmo
added a commit
to jimmo/micropython
that referenced
this pull request
Sep 7, 2020
MP and NimBLE must be on the same core (for synchronisation of the BLE ringbuf and the MP scheduler). However, in the current IDF versions (3.3 and 4.0) there are issues (e.g. micropython#6343) with running NimBLE on core 1. This change makes it possible to reliably run the BLE multitests.
|
Thanks @jimmo and @andrewleech for all the effort! |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
May 12, 2022
add board.LED to Metro M4 AirLift LIte and PyRuler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done in collaboration with @andrewleech
This started as just an implementation of NimBLE on Unix but ended up with lots of dependent changes and bugs fixed along the way. Ideally this would have been multiple PRs but I've tried to split each part into distinct commits. Other than the binding refactor (which is unfortunately very difficult to split), each commit is quite small.
Bug fixes:
Code cleanup:
Unix port:
This allows (for example) a Zephyr HCI controller running on an nRF to be used from the Unix port.
Addressing:
This is tested using the multitests on:
More testing required on
(I'm working on those right now)
TODO: