modbluetooth/hci: Create Uart object on heap to ensure gc tracks it correctly. #6299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34aaeea to
1d5f608
Compare
|
This issue was resolved in a better way in #6343 |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
May 12, 2022
Fix signature of random.randrange() to show multiple signatures in stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the existing bluetooth / hci uart configuration where the uart is created in a static struct, the irq python function is left as a dangling object which the gc happily cleans up later. This means eventually further into the application, the uart.irq object is replaced with something quite different.