extmod/nimble: Add mutex bindings to micropython threading mutex. #6317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is the right approach as we won't always have threading enabled. Also NimBLE requires this to be a recursive mutex which I'm not sure the mp_thread_mutex is. On bare-metal I think it's sufficient to build this on top of the existing MICROPY_PY_BLUETOOTH_ENTER (which prevents both context switching and provides mutex with the PENDSV context). On Unix we have the thread mutex which provides a similar thing. I'm working on adding NimBLE support to the Unix port and have an implementation of this working on that branch. |
|
This approach wasn't quite right, better fixed have been inlcuded in #6343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is needed, or whether this implementation is appropriate. Up here for discussion.