8000 Implement memory detection override. by neunhoef · Pull Request #11268 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Implement memory detection override. #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2020
Merged

Implement memory detection override. #11268

merged 4 commits into from
Mar 13, 2020

Conversation

neunhoef
Copy link
Member

No description provided.

@neunhoef neunhoef marked this pull request as ready for review March 13, 2020 16:27
@neunhoef neunhoef requested a review from jsteemann March 13, 2020 16:27
@neunhoef
Copy link
Member Author

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9028/

@neunhoef
Copy link
Member Author

The test failure is only the known one with resilience_move, which is in devel and will be fixed elsewhere. I think this can be merged.

@jsteemann jsteemann merged commit 72fa16d into devel Mar 13, 2020
@jsteemann jsteemann deleted the feature/override-memory-detection branch March 13, 2020 19:07
@graetzer
Copy link
Contributor

Why an environment variable and not an option?

@jsteemann
Copy link
Contributor

Because currently the default values for amount-of-RAM-based-options such as --rocksdb.block-cache-size are set in the constructor of the ApplicationFeatures, when command line options and config file options have not been parsed yet. The value of a startup option is only available after ApplicationFeature::parseOptions().

ObiWahn added a commit that referenced this pull request Mar 16, 2020
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
2076d3f 
…-fix/validation-fixes-and-improvements

* 'devel' of https://github.com/arangodb/arangodb: (25 commits)
  Do not instantiate snipped if not collection is found on the server. (#11281)
  Add entries related to search features in 3.7
  fix bug (#11279)
  Docs: Add DocuBlocks for document validation. (#11228)
  Feature/ngram similarity function (#11276)
  Fixed production check, removed assertion (#11273)
  fix compile warning
  Cluster Metrics (#11234)
  Feature/satellite graphs (#11015)
  fix newly created supervision bug with incremental updates (#11269)
  remove useless std::cout output
  fix yet more compile warnings
  Implement memory detection override. (#11268)
  implement a global deadline when running testcode in the local arangosh (#11123)
  Encryption key rotation (#11080)
  fix compile warnings
  fix compile warnings
  Feature/aql subquery execution block impl execute implementation (#10606)
  missing metrics (#10625)
  Bug fix/supervision server cleanup (#11187)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neunhoef @graetzer @jsteemann
0