Conversation
maierlars
approved these changes
Mar 6, 2020
…-fix/missing-metrics
…-fix/missing-metrics
…-fix/missing-metrics
…-fix/missing-metrics
maierlars
approved these changes
Mar 13, 2020
maierlars
requested changes
Mar 13, 2020
Contributor
There was a problem hiding this comment.
When using the option --server.statistics-history false the StatisticsWorker thread will be a nullptr and thus any call /_admin(metrics will crash the server.
…-fix/missing-metrics
Member
|
The request of @maierlars has been partly addressed, the crash is fixed. |
ObiWahn
added a commit
that referenced
this pull request
Mar 16, 2020
…-fix/validation-fixes-and-improvements * 'devel' of https://github.com/arangodb/arangodb: (25 commits) Do not instantiate snipped if not collection is found on the server. (#11281) Add entries related to search features in 3.7 fix bug (#11279) Docs: Add DocuBlocks for document validation. (#11228) Feature/ngram similarity function (#11276) Fixed production check, removed assertion (#11273) fix compile warning Cluster Metrics (#11234) Feature/satellite graphs (#11015) fix newly created supervision bug with incremental updates (#11269) remove useless std::cout output fix yet more compile warnings Implement memory detection override. (#11268) implement a global deadline when running testcode in the local arangosh (#11123) Encryption key rotation (#11080) fix compile warnings fix compile warnings Feature/aql subquery execution block impl execute implementation (#10606) missing metrics (#10625) Bug fix/supervision server cleanup (#11187) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
Pull requests are an essential collaborative tool for modern software development.
The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:
Acceptance Checklist
The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)
Related Information
(Please reference tickets / specification etc )
Testing & Verification
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This PR adds tests that were used to verify all changes:
Additionally:
(Include link to Jenkins run etc)
Documentation
CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.