8000 missing metrics by kvahed · Pull Request #10625 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

missing metrics #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Mar 13, 2020
Merged

missing metrics #10625

merged 50 commits into from
Mar 13, 2020

Conversation

kvahed
Copy link
Contributor
@kvahed kvahed commented Dec 4, 2019

Pull Request Guidelines

Pull requests are an essential collaborative tool for modern software development.

The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

  • Reduce the amount of recurring defects
  • Reduce the impact to the other developer’s time and energy spent on defects in your code
  • Increase the overall autonomy and productivity of individual developers

Acceptance Checklist

The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply

Scope & Purpose

(Can you describe what functional change your PR is trying to effect?)

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Related Information

(Please reference tickets / specification etc )

  • There is a GitHub Issue reported by a Community User:
  • There is an internal planning ticket:
  • There is a JIRA Ticket number (In case a customer was affected / involved):
  • There is a design document:

Testing & Verification

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This PR adds tests that were used to verify all changes:

  • Added Regression Tests (Only for bug-fixes)
  • Added new C++ Unit Tests (Either GoogleTest or Catch-Test)
    • Did you add tests for a new RestHandler subclass ?
    • Did you add new mocks of underlying code layers to be able to verify your functionality ?
    • ...
  • Added new integration tests (i.e. in shell_server / shell_server_aql)
  • Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

  • There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
  • I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Think about whether the new code you added is modular enough to be
easily testable by unit tests written with GTest / Catch. It is not good if your feature is so interconnected
that it prevents other people from writing their own unit gests. It should be possible
to use your code in future without extensively mocking your classes.
A bad example that required some extensive effort would be the storage engine API.

Documentation

All new Features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the changelog so that
developers and users have a concise overview.

  • Added a Changelog Entry (referencing the corresponding public or internal issue number)
  • Added entry to Release Notes
  • Added a new section in the Manual
  • Added a new section in the http API
  • Added Swagger examples for the http API

CLA Note

Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

@kvahed kvahed added the 9 WIP label Dec 4, 2019
@kvahed kvahed self-assigned this Dec 4, 2019
@jsteemann jsteemann added this to the devel milestone Jan 30, 2020
kvahed added 22 commits March 10, 2020 09:51
@kvahed
only counters outstanding with new key scheme
7248328
@kvahed
fixed label behaviour
a8d44c0
@kvahed
corrected retrieve bahaviour.
fca1583
@kvahed
feature tests
365fa26
@kvahed
feature tests
fbd7bea
@kvahed
fetching bug
52e6c8f
@kvahed
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
99eaed8 
…-fix/missing-metrics
@kvahed
fixed uint64_t
51c50ee
@kvahed
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
ef284bb 
…-fix/missing-metrics
@kvahed
wtf
ce4e870
@kvahed
histogram count labels
ee61f66
@kvahed
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
a80de52 
…-fix/missing-metrics
@kvahed
histogram feature tests
6ebb0b9
@kvahed
histogram feature tests
3a800b4
@kvahed
gauge feature tests
10c3aa7
@kvahed
long int ambiguity
8277d0a
@kvahed
windows warning
ea159b2
@kvahed
separator on wrong side
94be7d7
@kvahed
windows warnings
853f0fc
@kvahed
added role to labels
2c05c51
@kvahed
http requests
3b34ab5
@kvahed
added agency commit histogram
c955d13
maierlars
maierlars suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor
@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the option --server.statistics-history false the StatisticsWorker thread will be a nullptr and thus any call /_admin(metrics will crash the server.

@mchacki
Copy link
Member
mchacki commented Mar 13, 2020

The request of @maierlars has been partly addressed, the crash is fixed.
However we desire a different version of the fix in another PR.

@mchacki mchacki merged commit 376a8cc into devel Mar 13, 2020
@mchacki mchacki deleted the bug-fix/missing-metrics branch March 13, 2020 14:17
ObiWahn added a commit that referenced this pull request Mar 16, 2020
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into bug…
2076d3f 
…-fix/validation-fixes-and-improvements

* 'devel' of https://github.com/arangodb/arangodb: (25 commits)
  Do not instantiate snipped if not collection is found on the server. (#11281)
  Add entries related to search features in 3.7
  fix bug (#11279)
  Docs: Add DocuBlocks for document validation. (#11228)
  Feature/ngram similarity function (#11276)
  Fixed production check, removed assertion (#11273)
  fix compile warning
  Cluster Metrics (#11234)
  Feature/satellite graphs (#11015)
  fix newly created supervision bug with incremental updates (#11269)
  remove useless std::cout output
  fix yet more compile warnings
  Implement memory detection override. (#11268)
  implement a global deadline when running testcode in the local arangosh (#11123)
  Encryption key rotation (#11080)
  fix compile warnings
  fix compile warnings
  Feature/aql subquery execution block impl execute implementation (#10606)
  missing metrics (#10625)
  Bug fix/supervision server cleanup (#11187)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maierlars maierlars maierlars requested changes

Assignees

@kvahed kvahed

Labels
9 WIP
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
5 participants
@kvahed @mchacki @maierlars @jsteemann @Simran-B
0