implement a global deadline when running testcode in the local arangosh #11123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the local arangosh that also runs the test framework
…out-run-in-local-arangosh
The mixture of double (seconds), double (millisconds), chrono::duration<dobule>, chrono::milliseconds, etc. should be cleaned up!!!
1128ac7 to
6d222ec
Compare
|
The results of this can be observed by specifying a small timeout: |
ObiWahn
suggested changes
Feb 20, 2020
…out-run-in-local-arangosh
…out-run-in-local-arangosh
ObiWahn
suggested changes
Feb 25, 2020
…ngodb/arangodb into feature/timout-run-in-local-arangosh
ObiWahn
suggested changes
Mar 9, 2020
|
You use |
ObiWahn
suggested changes
Mar 9, 2020
lib/V8/v8-utils.cpp
Outdated
| //////////////////////////////////////////////////////////////////////////////// | ||
| /// @brief set a point in time after which we will abort external connection | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
| static double executionDeadline = 0.0; |
lib/V8/v8-utils.cpp
Outdated
| return delta; | ||
| } | ||
|
|
||
| std::chrono::milliseconds correctTimeoutToExecutionDeadline(std::chrono::milliseconds timeout) { |
|
Again - we may fix the usage of chrono once we do this for js_download. its out of scope for this PR. |
|
Just use chrono for your new code and cast to others as required. |
|
I (we) did, on all places that already use it. |
ObiWahn
reviewed
Mar 9, 2020
|
tests green. |
…out-run-in-local-arangosh
|
tests all blue. |
jsteemann
suggested changes
Mar 13, 2020
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
…out-run-in-local-arangosh
…out-run-in-local-arangosh
ObiWahn
added a commit
that referenced
this pull request
Mar 16, 2020
…-fix/validation-fixes-and-improvements * 'devel' of https://github.com/arangodb/arangodb: (25 commits) Do not instantiate snipped if not collection is found on the server. (#11281) Add entries related to search features in 3.7 fix bug (#11279) Docs: Add DocuBlocks for document validation. (#11228) Feature/ngram similarity function (#11276) Fixed production check, removed assertion (#11273) fix compile warning Cluster Metrics (#11234) Feature/satellite graphs (#11015) fix newly created supervision bug with incremental updates (#11269) remove useless std::cout output fix yet more compile warnings Implement memory detection override. (#11268) implement a global deadline when running testcode in the local arangosh (#11123) Encryption key rotation (#11080) fix compile warnings fix compile warnings Feature/aql subquery execution block impl execute implementation (#10606) missing metrics (#10625) Bug fix/supervision server cleanup (#11187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables us to have a timeout for testfiles that we eval' into the testing.js arangosh by
runInLocalArangosh.