Encryption key rotation #11080
Merged
Encryption key rotation #11080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests blue |
jsteemann
approved these changes
Feb 17, 2020
…ryption-key-rotate
jsteemann
approved these changes
Mar 13, 2020
lib/Basics/FileUtils.cpp
Outdated
Comment on lines
368
to
380
| //bool copyDirectoryRecursive(std::string const& source, std::string const& target, | ||
| // std::function<bool(std::string const&)> const& filter, | ||
| // std::string& error) { | ||
| // | ||
| // // "auto lambda" will not work here | ||
| // std::function<TRI_copy_recursive_e(std::string const&)> lambda = | ||
| // [&filter] (std::string const& pathname) -> TRI_copy_recursive_e { | ||
| // return filter(pathname) ? TRI_COPY_IGNORE : TRI_COPY_COPY; | ||
| // }; | ||
| // | ||
| // return copyDirectoryRecursive(source, target, lambda, error); | ||
| // | ||
| //} // copyDirectoryRecursive (bool filter()) |
There was a problem hiding this comment.
Let's remove this altogether if not needed!
lib/Basics/FileUtils.h
Outdated
Comment on lines
90
to
92
| //bool copyDirectoryRecursive(std::string const& source, std::string const& target, | ||
| // std::function<bool(std::string const&)> const& filter, | ||
| // std::string& error); |
…ryption-key-rotate
ObiWahn
added a commit
that referenced
this pull request
Mar 16, 2020
…-fix/validation-fixes-and-improvements * 'devel' of https://github.com/arangodb/arangodb: (25 commits) Do not instantiate snipped if not collection is found on the server. (#11281) Add entries related to search features in 3.7 fix bug (#11279) Docs: Add DocuBlocks for document validation. (#11228) Feature/ngram similarity function (#11276) Fixed production check, removed assertion (#11273) fix compile warning Cluster Metrics (#11234) Feature/satellite graphs (#11015) fix newly created supervision bug with incremental updates (#11269) remove useless std::cout output fix yet more compile warnings Implement memory detection override. (#11268) implement a global deadline when running testcode in the local arangosh (#11123) Encryption key rotation (#11080) fix compile warnings fix compile warnings Feature/aql subquery execution block impl execute implementation (#10606) missing metrics (#10625) Bug fix/supervision server cleanup (#11187) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Allow to rotate encryption keys (by re-encrypting the actual internal key)
Testing & Verification
This PR adds tests that were used to verify all changes:
http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/8513/
Documentation