[go: up one dir, main page]
Page MenuHomePhabricator
Differential D265836

Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event
ClosedPublic
Actions

Authored by • jdescottes on Sep 23 2025, 4:31 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 15 2025, 11:34 PM
Unknown Object (File)
Oct 11 2025, 3:15 AM
Unknown Object (File)
Oct 10 2025, 9:38 AM
Unknown Object (File)
Oct 7 2025, 9:56 PM
Unknown Object (File)
Oct 6 2025, 4:12 PM
Unknown Object (File)
Oct 4 2025, 11:45 PM
Unknown Object (File)
Oct 4 2025, 12:00 PM
Unknown Object (File)
Oct 4 2025, 7:49 AM
View All 11 Files
Subscribers
reviewbot
Sasha
whimboo

Details

Reviewers
Sasha
Group Reviewers
webdriver-reviewers-rotation
Commits
rFIREFOXAUTOLAND8d430b130993: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event…
rFIREFOXAUTOLAND8a4ca8ef7ebe: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event…
Bugzilla Bug ID
1970293

Diff Detail

Event Timeline

• jdescottes created this revision.Sep 23 2025, 4:31 PM
Herald added a project: secure-revision. · View Herald TranscriptSep 23 2025, 4:31 PM
Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript
Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript
phab-bot published this revision for review.Sep 23 2025, 4:31 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Harbormaster completed remote builds in B851050: Diff 1126286.Sep 23 2025, 4:48 PM
• jdescottes planned changes to this revision.Sep 24 2025, 10:12 AM

I need to update the corresponding browser mochitest here.

• jdescottes requested review of this revision.Sep 24 2025, 2:45 PM
• jdescottes updated this revision to Diff 1126949.
Harbormaster completed remote builds in B851555: Diff 1126949.Sep 24 2025, 3:05 PM
Sasha accepted this revision.Sep 24 2025, 4:59 PM
Sasha added a project: testing-exception-elsewhere (Please comment explaining where the tests are).
Sasha added a subscriber: Sasha.

Seems quite straightforward. Thanks!

testing-exception-elsewhere: Covered by existing tests + additional tests and updates in the previous patch.

This revision is now accepted and ready to land.Sep 24 2025, 4:59 PM
• jdescottes updated this revision to Diff 1127561.Sep 25 2025, 10:00 AM
• jdescottes added a comment.Sep 25 2025, 10:02 AM

Thanks for the reviews, I only slightly updated the ini files since the download events are currently not supported on Android

• jdescottes updated this revision to Diff 1127562.Sep 25 2025, 10:02 AM
Harbormaster completed remote builds in B852070: Diff 1127562.Sep 25 2025, 10:17 AM
Harbormaster completed remote builds in B852069: Diff 1127561.Sep 25 2025, 10:21 AM
whimboo added a subscriber: whimboo.Sep 25 2025, 11:00 AM

There is one thing that I noticed. Otherwise as Sasha said, it looks good!

remote/webdriver-bidi/modules/root/browsingContext.sys.mjs
2007–2008
• jdescottes marked an inline comment as done.Sep 25 2025, 7:42 PM

thanks for the review!

remote/webdriver-bidi/modules/root/browsingContext.sys.mjs
2007–2008

I can fix the order, but note that for canceled we should not have filepath set at all: https://www.w3.org/TR/webdriver-bidi/#cddl-type-browsingcontextdownloadcanceledparams

Maybe I will just set filepath separately for clarity then.

• jdescottes updated this revision to Diff 1127987.Sep 25 2025, 7:49 PM
• jdescottes marked an inline comment as done.
reviewbot added a subscriber: reviewbot.Sep 25 2025, 8:01 PM

The analysis task source-test-mozlint-eslint failed, but we could not detect any defect.
Please check this task manually.

If you see a problem in this automated review, please report it here.

Harbormaster failed remote builds in B852378: Diff 1127987!Sep 25 2025, 8:02 PM
This revision was landed with ongoing or failed builds.Sep 25 2025, 9:12 PM
Closed by commit rFIREFOXAUTOLAND8a4ca8ef7ebe: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event… (authored by • jdescottes). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jdescottes added a commit: rFIREFOXAUTOLAND8a4ca8ef7ebe: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….
sstanca reopened this revision.Sep 25 2025, 10:54 PM
This revision is now accepted and ready to land.Sep 25 2025, 10:54 PM
sstanca added a reverting change: rFIREFOXAUTOLAND1addeb5b1d90: Revert "Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….Sep 25 2025, 10:54 PM
• jdescottes updated this revision to Diff 1128262.Sep 26 2025, 4:42 AM
This revision was landed with ongoing or failed builds.Sep 26 2025, 4:46 AM
Closed by commit rFIREFOXAUTOLAND8d430b130993: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event… (authored by • jdescottes). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jdescottes added a commit: rFIREFOXAUTOLAND8d430b130993: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….
Harbormaster completed remote builds in B852584: Diff 1128262.Sep 26 2025, 4:59 AM
• jdescottes mentioned this in rFIREFOXBETA8a4ca8ef7ebe: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….Oct 13 2025, 11:45 AM
• jdescottes mentioned this in rFIREFOXBETA8d430b130993: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….
• jdescottes mentioned this in rFIREFOXRELEASE8a4ca8ef7ebe: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….Nov 3 2025, 10:47 AM
• jdescottes mentioned this in rFIREFOXRELEASE8d430b130993: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
remote/
shared/
39 lines93%
Loading...
listeners/
13 lines94%
Loading...
test/
browser/
33 lines--
webdriver-bidi/
modules/
root/
50 lines97%
Loading...
testing/
web-platform/
meta/
webdriver/
tests/
bidi/
browsing_context/
download_end/
16 lines--
6 lines--

Diff 1128264

View Options

remote/shared/NavigationManager.sys.mjs

Loading...
View Options

remote/shared/listeners/DownloadListener.sys.mjs

Loading...
View Options

remote/shared/listeners/test/browser/browser_DownloadListener.js

Loading...
View Options

remote/webdriver-bidi/modules/root/browsingContext.sys.mjs

Loading...
View Options

testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/download_end.py.ini

Loading...
View Options

testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/status.py.ini

Loading...
Privacy · Cookies · Legal