[go: up one dir, main page]
Page MenuHomePhabricator
Differential D265835

Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs
ClosedPublic
Actions

Authored by • jdescottes on Sep 23 2025, 4:31 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Dec 14, 2:33 AM
Unknown Object (File)
Oct 16 2025, 9:16 AM
Unknown Object (File)
Oct 10 2025, 11:13 AM
Unknown Object (File)
Oct 9 2025, 8:45 AM
Unknown Object (File)
Oct 8 2025, 3:47 AM
Unknown Object (File)
Oct 5 2025, 1:00 AM
Unknown Object (File)
Oct 4 2025, 7:52 PM
Unknown Object (File)
Oct 4 2025, 4:48 AM
View All 11 Files
Subscribers
Sasha
whimboo
wpt-webdriver-watchers

Details

Reviewers
Sasha
Group Reviewers
webdriver-reviewers-rotation
Commits
rFIREFOXAUTOLAND0bf3cbb89d11: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs…
rFIREFOXAUTOLANDf3264d884d5c: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs…
Bugzilla Bug ID
1970293

Diff Detail

Event Timeline

• jdescottes created this revision.Sep 23 2025, 4:31 PM
Herald added a project: secure-revision. · View Herald TranscriptSep 23 2025, 4:31 PM
Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript
Herald added a subscriber: wpt-webdriver-watchers. · View Herald Transcript
• jdescottes added a child revision: D265836: Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event.Sep 23 2025, 4:31 PM
phab-bot published this revision for review.Sep 23 2025, 4:31 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Harbormaster completed remote builds in B851049: Diff 1126285.Sep 23 2025, 4:47 PM
• jdescottes updated this revision to Diff 1126948.Sep 24 2025, 2:45 PM
Harbormaster completed remote builds in B851554: Diff 1126948.Sep 24 2025, 3:05 PM
Sasha accepted this revision.Sep 24 2025, 4:56 PM
Sasha added a project: testing-approved.
Sasha added a subscriber: Sasha.

Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 24 2025, 4:56 PM
whimboo added a subscriber: whimboo.Sep 25 2025, 11:51 AM
whimboo added inline comments.
testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/download_end.py.ini
8

Do we know why this is always failing? It would be good to have a separate bug for it filed and put as reference here. Same for the above as well.

Also why are we still failing all tests in status.py?

• jdescottes marked an inline comment as done.Sep 25 2025, 7:45 PM
• jdescottes added inline comments.
testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/download_end.py.ini
8

Here I'm only fixing the test, the implementation patch is next in the queue and the metadata is updated there.

I was not sure which order was the best, but since the test was buggy, my implementation was not passing any test so I think I prefer this order for the patches.

Closed by commit rFIREFOXAUTOLANDf3264d884d5c: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs… (authored by • jdescottes). · Explain WhySep 25 2025, 9:12 PM
This revision was automatically updated to reflect the committed changes.
• jdescottes marked an inline comment as done.
• jdescottes added a commit: rFIREFOXAUTOLANDf3264d884d5c: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….
sstanca reopened this revision.Sep 25 2025, 10:54 PM
This revision is now accepted and ready to land.Sep 25 2025, 10:54 PM
sstanca added a reverting change: rFIREFOXAUTOLAND1addeb5b1d90: Revert "Bug 1970293 - [bidi] Add support for browsingContext.downloadEnd event….Sep 25 2025, 10:54 PM
• jdescottes updated this revision to Diff 1128261.Sep 26 2025, 4:42 AM
This revision was landed with ongoing or failed builds.Sep 26 2025, 4:46 AM
Closed by commit rFIREFOXAUTOLAND0bf3cbb89d11: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs… (authored by • jdescottes). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jdescottes added a commit: rFIREFOXAUTOLAND0bf3cbb89d11: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….
Harbormaster completed remote builds in B852583: Diff 1128261.Sep 26 2025, 4:58 AM
whimboo added inline comments.Sep 26 2025, 6:43 AM
testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/download_end.py.ini
8

Ah, yes. That makes sense then. Thanks for clarifying.

• jdescottes mentioned this in rFIREFOXBETAf3264d884d5c: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….Oct 13 2025, 11:45 AM
• jdescottes mentioned this in rFIREFOXBETA0bf3cbb89d11: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….
• jdescottes mentioned this in rFIREFOXRELEASEf3264d884d5c: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….Nov 3 2025, 10:47 AM
• jdescottes mentioned this in rFIREFOXRELEASE0bf3cbb89d11: Bug 1970293 - [wdspec] Update downloadEnd wdspec tests to match specs….

Revision Contents
Changeset List

PathSize
testing/
web-platform/
meta/
webdriver/
tests/
bidi/
browsing_context/
download_end/
7 lines
tests/
webdriver/
tests/
bidi/
browsing_context/
download_end/
65 lines
4 lines
support/
http_handlers/
5 lines

Diff 1128265

View Options

testing/web-platform/meta/webdriver/tests/bidi/browsing_context/download_end/download_end.py.ini

Loading...
View Options

testing/web-platform/tests/webdriver/tests/bidi/browsing_context/download_end/download_end.py

Loading...
View Options

testing/web-platform/tests/webdriver/tests/bidi/browsing_context/download_end/status.py

Loading...
View Options

testing/web-platform/tests/webdriver/tests/support/http_handlers/headers.py

Loading...
Privacy · Cookies · Legal