User Details
User Details
- User Since
- Apr 4 2022, 5:09 PM (193 w, 4 d)
- Availability
- Available
- Review Queue
- 2
Today
Today
Sasha added inline comments to D276819: Bug 1964905 - Add "owningBrowsingContext" to "DOMModalDialogClosed" event details..
Sasha updated the diff for D276821: Bug 1964905 - [webdriver-bidi] Use "owningBrowsingContext" to handle prompts..
Yesterday
Yesterday
Sasha accepted D276894: Bug 2006716 - Reformat entire repo with `ruff-format` (`black` replacement) r?#linter-reviewers,ahal,sylvestre.
r+ for testing/marionette/client/marionette_driver/ and testing/web-platform/mozilla/tests/webdriver/bidi/.
Sasha added inline comments to D276821: Bug 1964905 - [webdriver-bidi] Use "owningBrowsingContext" to handle prompts..
Sasha added inline comments to D276819: Bug 1964905 - Add "owningBrowsingContext" to "DOMModalDialogClosed" event details..
Sasha updated the diff for D276821: Bug 1964905 - [webdriver-bidi] Use "owningBrowsingContext" to handle prompts..
Sasha accepted D276803: Bug 1944570 - [webdriver-bidi] Support executing “script.evaluate” and “script.callFunction” for chrome browsing contexts..
Thanks, Henrik. I think that looks fine.
Sasha accepted D276802: Bug 1944570 - [remote] Only use the webprogress in the RootTransport module for content browsing contexts..
: Tests are in this revision.
Sasha accepted D276801: Bug 1944570 - [remote] Allow loading the MessageHandlerFrameActor for chrome scope..
Wed, Dec 17
Wed, Dec 17
Sasha added a reviewer for D276819: Bug 1964905 - Add "owningBrowsingContext" to "DOMModalDialogClosed" event details.: Gijs.
Sasha updated the test plan for D276821: Bug 1964905 - [webdriver-bidi] Use "owningBrowsingContext" to handle prompts..
Tue, Dec 16
Tue, Dec 16
Sasha accepted D275812: Bug 1851788 - [webdriver-bidi] Enhance "browsingContext.getTree" command for chrome scope when root parameter is set..
Thanks, Henrik. I think it looks fine now.
I just have a couple of comments.
Sasha committed rFIREFOXAUTOLANDb54fa3b1aff0: Bug 2006244 - Remove unneeded metadata for css/css-overflow/overflow-img-border… (authored by Sasha).
Bug 2006244 - Remove unneeded metadata for css/css-overflow/overflow-img-border…
Fri, Dec 12
Fri, Dec 12
Wed, Dec 10
Wed, Dec 10
Sasha accepted D275733: Bug 2003857 - [bidi] Wait for document to be visible in browsingContext.create with background=false.
I think it would be fine with me to try this.
Mon, Dec 8
Mon, Dec 8
Sasha committed rFIREFOXBETAb40460c1fc66: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window. (authored by Sasha).
Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.
Sasha committed rFIREFOXBETA47a9b982fe0f: Bug 2002721 - [webdriver-bidi] Make sure that "script.realmCreated" event is… (authored by Sasha).
Bug 2002721 - [webdriver-bidi] Make sure that "script.realmCreated" event is…
Sasha committed rFIREFOXBETA24d78adac958: Bug 2003992 - [webdriver-bidi] Throw an error when calling "emulation. (authored by Sasha).
Bug 2003992 - [webdriver-bidi] Throw an error when calling "emulation.
Sasha committed rFIREFOXBETA303c960d005e: Bug 2003992 - [wdspec] Add a test case with "locale" equal "undefined" for… (authored by Sasha).
Bug 2003992 - [wdspec] Add a test case with "locale" equal "undefined" for…
Sasha committed rFIREFOXBETAe8cc9eb24c6f: Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXBETA174ef152042b: Bug 2000651 - [wpt] Add support for "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [wpt] Add support for "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXBETA0f883d56b313: Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXBETAa689946d0f7a: Bug 2000651 - Add an API to BrowsingContext to override screen dimensions. (authored by Sasha).
Bug 2000651 - Add an API to BrowsingContext to override screen dimensions.
Sasha committed rFIREFOXBETAe2361552a2e8: Bug 2002505 - Update metadata for intersection-observer/scroll-margin… (authored by Sasha).
Bug 2002505 - Update metadata for intersection-observer/scroll-margin…
Sasha committed rFIREFOXBETA975653d57082: Bug 1706066 - [devtools] Extend mochitests to checks for maxTouchPoints in a… (authored by Sasha).
Bug 1706066 - [devtools] Extend mochitests to checks for maxTouchPoints in a…
Sasha committed rFIREFOXBETA9700371b499e: Bug 1706066 - Always use maxTouchPointsOverride for top level browsing context. (authored by Sasha).
Bug 1706066 - Always use maxTouchPointsOverride for top level browsing context.
Sasha committed rFIREFOXBETA71cfba671800: Bug 1999352 - Update metadata for forced-colors-mode/forced-colors-mode-*.html… (authored by Sasha).
Bug 1999352 - Update metadata for forced-colors-mode/forced-colors-mode-*.html…
Sasha committed rFIREFOXBETA4e8b34277213: Bug 1995691 - [wdspec] Add checks for overriding "Accept-Language" header with… (authored by Sasha).
Bug 1995691 - [wdspec] Add checks for overriding "Accept-Language" header with…
Sasha committed rFIREFOXBETA391b807db330: Bug 1995691 - Override "Accept-Language" header when browsingContext. (authored by Sasha).
Bug 1995691 - Override "Accept-Language" header when browsingContext.
Sasha added a comment to D275235: Bug 2003857 - [wdspec] Add test for parallel calls to browsingContext.create.
Sasha accepted D275234: Bug 2003857 - [bidi] Update helper to wait for visibility to use visibilityChange event.
Good call! Waiting for an event is definitely better than polling.
Fri, Dec 5
Fri, Dec 5
r+ for marionette harness tests
Sasha committed rFIREFOXAUTOLANDb40460c1fc66: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window. (authored by Sasha).
Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.
Sasha committed rFIREFOXAUTOLAND47a9b982fe0f: Bug 2002721 - [webdriver-bidi] Make sure that "script.realmCreated" event is… (authored by Sasha).
Bug 2002721 - [webdriver-bidi] Make sure that "script.realmCreated" event is…
Sasha added inline comments to D274415: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.open..
Thu, Dec 4
Thu, Dec 4
Sasha accepted D275045: Bug 2003857 - [bidi] Update waitForVisibility helper to wait either for visible or hidden state.
Thanks for the update, it makes much more sense now!
Sasha accepted D274957: Bug 2003857 - [bidi] Wait for document to be visible in browsingContext.create with background=false.
Looks good to me!
Sasha committed rFIREFOXAUTOLAND303c960d005e: Bug 2003992 - [wdspec] Add a test case with "locale" equal "undefined" for… (authored by Sasha).
Bug 2003992 - [wdspec] Add a test case with "locale" equal "undefined" for…
Sasha committed rFIREFOXAUTOLAND24d78adac958: Bug 2003992 - [webdriver-bidi] Throw an error when calling "emulation. (authored by Sasha).
Bug 2003992 - [webdriver-bidi] Throw an error when calling "emulation.
Sasha committed rFIREFOXAUTOLANDe8cc9eb24c6f: Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXAUTOLAND0f883d56b313: Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXAUTOLAND174ef152042b: Bug 2000651 - [wpt] Add support for "emulation.setScreenSettingsOverride"… (authored by Sasha).
Bug 2000651 - [wpt] Add support for "emulation.setScreenSettingsOverride"…
Sasha committed rFIREFOXAUTOLANDa689946d0f7a: Bug 2000651 - Add an API to BrowsingContext to override screen dimensions. (authored by Sasha).
Bug 2000651 - Add an API to BrowsingContext to override screen dimensions.
Sasha added inline comments to D273426: Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride" command..
Sasha updated the test plan for D273428: Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride" command..
Sasha abandoned D274955: Bug 2000651 - [webdriver-bidi] Throw an error when calling "emulation.setLocaleOverride" with "locale" argument equal "undefined"..
Moved it to its own bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2003992.
Wed, Dec 3
Wed, Dec 3
Sasha added inline comments to D273428: Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride" command..
Sasha updated the test plan for D274415: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.open..
Tue, Dec 2
Tue, Dec 2
Sasha planned changes to D274415: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.open..
I have to add a test for the event order.
Sasha planned changes to D274756: Bug 2002721 - [webdriver-bidi] Make sure that "script.realmCreated" event is sent after a browser element is attached to a browser context..
Ok, I still have to make sure that the order of the events is also correct.
Sasha removed a reviewer for D274415: Bug 2002721 - [wdspec] Add a test for "script.realmCreated" event for window.open.: whimboo.
Sasha updated the test plan for D273428: Bug 2000651 - [wdspec] Add tests for "emulation.setScreenSettingsOverride" command..
Sasha added inline comments to D273426: Bug 2000651 - [webdriver-bidi] Implement "emulation.setScreenSettingsOverride" command..