Add suggestion role #1134
Add suggestion role #1134
Conversation
There was a problem hiding this comment.
In addition to addressing the wording-related comments and questions, please also add suggestion to the appropriate list under https://w3c.github.io/aria/#roles_categorization
There was a problem hiding this comment.
I think the words are ok, but I think this role needs an example to fully explain it.
I had to look at the explainer to understand where the markup would go (it's embedded in the content).
I think the -cat/+dog code example from the explainer would be helpful here.
There was a problem hiding this comment.
Thanks for the example, @aleventhal!
Looks good!
+1
|
Looks good to me overall, but as I'm sitting here implementing support for this role in Orca, I have a question: Your text says:
Can there be other children, like a paragraph explaining why the proposed insertion and/or deletion should be made? Or a time stamp? Or am I guaranteed to only find Arguably Orca should handle both scenarios because authors. But it would be nice to know (and perhaps see text in the spec stating) what the right usage looks like. Also, if we do want to prevent authors from putting non- |
…ion but may be combined with annotations
|
@joanmarie PTAL, I updated the text to make this more clear.
|
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
There was a problem hiding this comment.
I like it! Thanks for adding clarity regarding other possible children!!
There was a problem hiding this comment.
No big concerns, but I think it is very important that the normative language be specific, especially wrt the responsible party. Most of my suggestions are related to that concern.
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
|
@mcking65 I think I got everything, but I needed to do some polish after as there was an incomplete sentence snippet that remained. Can you take a look? |
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
There was a problem hiding this comment.
Looks good. I just made one minor editorial suggestion.
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
* Relates to ARIA Annotations, issue #749 Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com> Co-Authored-By: Matt King <a11yThinker@Gmail.com>
Relates to ARIA Annotations, issue #749
Preview | Diff