8000 Add suggestion role by aleventhal · Pull Request #1134 · w3c/aria · GitHub
[go: up one dir, main page]
Skip to content

Add suggestion role #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnurthen merged 21 commits into from
Feb 13, 2020
Merged

Add suggestion role #1134

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fca5644
Add suggestion role
Dec 11, 2019
07e8c9b
Fix tabs
Dec 11, 2019
b6ec793
Fix tabs
Dec 11, 2019
3de920d
Add suggestion role
Dec 11, 2019
37637d0
Merge branch 'suggestion_role' of github.com:w3c/aria into suggestion…
Dec 11, 2019
74ddc01
Fix tabs
Dec 11, 2019
2a60d43
Single change
Jan 14, 2020
f288961
Add suggestion to roles categorization
Jan 14, 2020
89647d4
Add semantic sugar and improve wording
Jan 14, 2020
fd9a55c
Add example
Jan 24, 2020
d24179d
A suggestion must not include children other than the insertion/delet…
Jan 24, 2020
1871d99
Update index.html
aleventhal Jan 24, 2020
4d145ad
Update index.html
aleventhal Feb 7, 2020
8204194
Update index.html
aleventhal Feb 7, 2020
ac230b8
Update index.html
aleventhal Feb 7, 2020
96238a4
Update index.html
aleventhal Feb 7, 2020
ed3407e
Update index.html
aleventhal Feb 7, 2020
543f8cb
Don't use the term author for 2 different things
Feb 7, 2020
e544bec
Post-polish after accepting Matt's suggestions
Feb 7, 2020
6725363
Update index.html
aleventhal Feb 7, 2020
6e36557
Update index.html
aleventhal Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update index.html 
Co-Authored-By: Matt King <a11yThinker@Gmail.com>
  • Loading branch information
@aleventhal @mcking65
aleventhal and mcking65 authored Feb 7, 2020
commit 96238a47a2cdbef04517ba94d9da0041d7f4ba0b
3 changes: 2 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8224,7 +8224,8 @@ <h5>Presentational Roles Conflict Resolution</h5>
<p>For example, in an editing system that supports multiple authors, one author may suggest a change, and another author would be responsible
for accepting or rejecting the suggestion.
Authors MUST ensure that a <code>suggestion</code> contains either one <rref>insertion</rref> child or one <rref>deletion</rref> child or ensure that it contains two children where one is an <rref>insertion</rref> and the other is a <rref>deletion</rref>.
any other children. Additional information such as related comments, authoring info and time stamps MAY be provided via <pref>aria-description</pref> or <pref>aria-details</pref>.</p>
Authors MUST ensure a <code>suggestion</code> does not contain any other children.
Authors MAY use <pref>aria-details</pref> or <pref>aria-description</pref> to associate the <code>suggestion</code> with information,such as related comments, authoring info, and time stamps.</p>
<pre class="example highlight">
&lt;p&gt;
The best pet is a
Expand Down
0