feat: add JSON schema test cases #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Could you move this PR so that it targets |
96a7087 to
738465e
Compare
krzema12
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
🫨 😱 🤯 Kudos for compiling this eye-boggling list of test cases!
I've reviewed that these ones make sense, but there can be some that aren't present here, which I would comfortably leave for situations where someone reports an issue. Even if something's missing, I'm excited we'll have that extensive testing for the schema 🚀
738465e to
2b02027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #82.
It's a homogeneous change, extracted from #243 for easier reviewing and merging first.