8000 Add JSON schema · Issue #82 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

Add JSON schema #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krzema12 opened this issue Feb 2, 2023 · 3 comments · Fixed by #243
Closed

Add JSON schema #82

krzema12 opened this issue Feb 2, 2023 · 3 comments · Fixed by #243
Labels
enhancement New feature or request

Comments

@krzema12
Copy link
Member
krzema12 commented Feb 2, 2023

To make it easier to build the YAML.
It can be also added here: https://github.com/SchemaStore/schemastore so that it's available by default in IntelliJ-based IDEs.
@krzema12 krzema12 added the enhancement New feature or request label Feb 2, 2023
@Vampire
Copy link
Collaborator
Vampire commented Aug 29, 2024

Where do you think it makes most sense to host the JSON schema, or what would you prefer?

Basically the two options are to host it in the schemastore repository and thus through their site,
or to host it here and just have an entry in the schemastore catalog that points at the URL where the schema is hosted.

Both have their pros and cons.

For example hosting it here it is closer to the definition and can be developed together with it,
but we probably then here need to build some testing infrastructure.

Hosting it in the schemastore repository, all the infrastructure is already there and you can just throw positive and negative YAML files in the according directories so that the schema is tested against those using Ajv, but it is like having the typing in the catalog instead of with the action itself, besides that the typing specification should most probably change way more seldom than an action changing inputs / outputs.

@Vampire
Copy link
Collaborator
Vampire commented Aug 29, 2024

Actually, I think I'm sufficiently happy with the schema I created, now I just need to know where I should contribute it to. :-D

@krzema12
Copy link
Member Author

I'd prefer to own it, and keep it in this repo for now (even though we need to add some testing infra), and later on we can mirror it in the schema store or add a reference like you mentioned.

Vampire added a commit that referenced this issue Jan 26, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
42eddcb
@Vampire Vampire mentioned this issue Jan 26, 2025
Merged
Vampire added a commit that referenced this issue Jan 26, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
d700eeb
Vampire added a commit that referenced this issue Jan 26, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
5a7036c
Vampire added a commit that referenced this issue Jan 26, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
2807f69
Vampire added a commit that referenced this issue Jan 26, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
2b9a99a
Vampire added a commit that referenced this issue Jan 27, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
31c0ee8
Vampire added a commit that referenced this issue Jan 27, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
b46ab15
@krzema12 krzema12 mentioned this issue Jan 27, 2025
Merged
krzema12 pushed a commit that referenced this issue Jan 27, 2025
@Vampire
chore: migrate from K/JVM to KMP (#244)
9e0cc6c 
Part of #82.
Vampire added a commit that referenced this issue Jan 27, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
2d2fb2f
Vampire added a commit that referenced this issue Jan 27, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
970f1ed
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
def1b8e
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add JSON schema test cases (#82)
96a7087
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add JSON schema test cases (#82)
738465e
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
d4c8cc2
@krzema12 krzema12 mentioned this issue Jan 28, 2025
Merged
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add JSON schema test cases (#82)
2b02027
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
1b1c314
krzema12 pushed a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add JSON schema test cases (#250)
23e6a9a 
Part of #82.

It's a homogeneous change, extracted from
#243 for
easier reviewing and merging first.
Vampire added a commit that referenced this issue Jan 28, 2025
@Vampire
feat: add a JSON schema including test infrastructure (#82)
24765a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add a JSON schema including test infrastructure (#82) typesafegithub/github-actions-typing
2 participants
@Vampire @krzema12
0