8000 feat: add a JSON schema including test infrastructure (#82) by Vampire · Pull Request #243 · typesafegithub/github-actions-typing · GitHub
[go: up one dir, main page]
Skip to content

feat: add a JSON schema including test infrastructure (#82) #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: add a JSON schema including test infrastructure (#82) #243

merged 3 commits into from
Jan 29, 2025

Conversation

Vampire
Copy link
Collaborator
@Vampire Vampire commented Jan 26, 2025

Fixes #82

@Vampire Graphite App
Copy link
Collaborator Author
Vampire commented Jan 26, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

krzema12
krzema12 reviewed Jan 26, 2025
View reviewed changes
krzema12
krzema12 reviewed Jan 26, 2025
View reviewed changes
krzema12
krzema12 reviewed Jan 26, 2025
View reviewed changes
settings.gradle.kts Outdated
id("org.gradle.toolchains.foojay-resolver-convention") version ("0.9.0")
}

dependencyResolutionManagement {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the changes in this file? It's related to the question "why adding the JS target?".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The foojay resolver convention plugin always makes sense if you use JVM toolchains which you also did before, otherwise you cannot (or will not be able to in the future) auto-provision the needed toolchains.

The repositories are for the JS part of KMP as I greatly dislike plugins to add repositories to projects as that opens much wider the doors to supply chain attacks, so disabled the repository adding and added the necessary ones here.

The version catalog is for the Kotlin Wrappers for the JS libs.

krzema12
krzema12 reviewed Jan 26, 2025
View reviewed changes
@Vampire Vampire force-pushed the vampire/json-schema branch 4 times, most recently from 2807f69 to 2b9a99a Compare January 26, 2025 22:49
@Vampire Vampire changed the base branch from main to vampire/kjvm-to-kmp January 26, 2025 22:49
@Vampire Vampire mentioned this pull request Jan 26, 2025
Merged
@Vampire Vampire force-pushed the vampire/json-schema branch 2 times, most recently from 31c0ee8 to b46ab15 Compare January 27, 2025 02:50
@Vampire Vampire requested a review from krzema12 January 27, 2025 02:51
Base automatically changed from vampire/kjvm-to-kmp to main January 27, 2025 05:45
@krzema12 krzema12 mentioned this pull request Jan 27, 2025
Closed
@Vampire Vampire force-pushed the vampire/json-schema branch from b46ab15 to 2d2fb2f Compare January 27, 2025 10:06
@krzema12 krzema12 mentioned this pull request Jan 27, 2025
Closed
@Vampire Vampire force-pushed the vampire/json-schema branch from 2d2fb2f to 970f1ed Compare January 27, 2025 11:16
krzema12
krzema12 reviewed Jan 28, 2025
View reviewed changes
Copy link
Member
@krzema12 krzema12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass...

@Vampire Vampire force-pushed the vampire/json-schema branch from 970f1ed to 5fa5cd4 Compare January 28, 2025 11:27
@Vampire Vampire mentioned this pull request Jan 28, 2025
Merged
@Vampire Vampire force-pushed the vampire/json-schema branch from 5fa5cd4 to 8283f10 Compare January 28, 2025 12:18
@Vampire Vampire changed the base branch from main to vampire/json-schema-test-cases January 28, 2025 12:18
@Vampire Vampire force-pushed the vampire/json-schema-test-cases branch from 738465e to 2b02027 Compare January 28, 2025 12:48
@Vampire Vampire force-pushed the vampire/json-schema branch from 8283f10 to e6a7c1f Compare January 28, 2025 12:50
krzema12 pushed a commit that referenced this pull request Jan 28, 2025
@Vampire
feat: add JSON schema test cases (#250)
23e6a9a 
Part of #82.

It's a homogeneous change, extracted from
#243 for
easier reviewing and merging first.
Base automatically changed from vampire/json-schema-test-cases to main January 28, 2025 12:51
@Vampire Vampire force-pushed the vampire/json-schema branch from e6a7c1f to 607add1 Compare January 28, 2025 12:58
@Vampire Vampire mentioned this pull request Jan 28, 2025
Merged
@krzema12 krzema12 mentioned this pull request Jan 29, 2025
Merged
krzema12 added a commit to typesafegithub/github-actions-typing-catalog that referenced this pull request Jan 29, 2025
@krzema12
Enforce only .yml extension for types (#47)
9e59643 
For simplicity. Even though https://github.com/typesafegithub/github-actions-typing allows both extensions, it's good to be consistent in this repo and agree on a single extension. It lets us simplify the logic for using the typings from the catalog. In fact, in the server, we already read just `.yml`: https://github.com/typesafegithub/github-workflows-kt/blob/6349e0cda0bbca4e7b7364b006d0f53f5543bbe3/action-binding-generator/src/main/kotlin/io/github/typesafegithub/workflows/actionbindinggenerator/typing/TypesProviding.kt#L37-L39

Context: typesafegithub/github-actions-typing#243 (comment)
krzema12
krzema12 reviewed Jan 29, 2025
View reviewed changes
@krzema12 krzema12 merged commit aada8b7 into main Jan 29, 2025
5 checks passed
@krzema12 krzema12 deleted the vampire/json-schema branch January 29, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzema12 krzema12 krzema12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON schema
2 participants
@Vampire @krzema12
0