Swap the two setfacl commands #8290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We recently swapped the calls for good reasons in #7987. I think we should then update the description instead if it doesn't match the example. |
wouterj
approved these changes
Aug 30, 2017
setup/file_permissions.rst
Outdated
| @@ -55,8 +55,7 @@ following script to determine your web server user and grant the needed permissi | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The first ``setfacl`` command sets permissions on the existing files and | |||
| folders, while the second one sets permissions for future files and folders. | |||
| The first ``setfacl`` command sets permissions for future files and folder, while the second one sets permissions on the existing files and folders. | |||
There was a problem hiding this comment.
If you add a line break after the first word crossing the 72th character, this PR would be perfect! :) (if you don't have the time, we can do it during merging).
Update the setfacl description.
|
Thank you @zephyr-thomas. |
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 2.7: [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo Update the setfacl description. Update associations.rst Update proxy_examples.rst Fixed logger processor example
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 2.8: (25 commits) [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo Update the setfacl description. Update events.rst Fixed a minor syntax issue Update phpunit_bridge.rst First parameter to uniqid must be a string fix #8321 minor changes in Serializer Component Update filesystem.rst Update associations.rst Update proxy_examples.rst ...
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 3.3: (40 commits) [#8273] fix bundle registration code [#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst [#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description was not suitable for the given setfacl commands.