8000 Reworded the built-in web server articles for Symfony 3.3 #8273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 11, 2017
setup/built_in_web_server.rst
Outdated
|
|
||
| First, execute this command: | ||
|
|
||
| .. terminal:: |
HeahDude
reviewed
Aug 31, 2017
setup/built_in_web_server.rst
Outdated
| $bundles = array( | ||
| // ... | ||
|
|
||
| if (in_array($this->getEnvironment(), array('dev', 'test'))) { |
There was a problem hiding this comment.
if ('dev' === $this->getEnvironment()) { is enough.
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
… (javiereguiluz) This PR was squashed before being merged into the 3.3 branch (closes #8273). Discussion ---------- Reworded the built-in web server articles for Symfony 3.3 This fixes #8270. The current scenario for Symfony 3.3 is the worst possible: we don't have the web server by default (like in 3.2) ... and it's not easy to install it (like in 3.3+Flex or 4.0). That's why I propose to add a link in the main `setup.rst` article to the full explanation about installing and enabling the bundle. In 4.0, we can remove that link and simply say: run `symfony require web-server` and then, execute `./bin/console server:run`. Commits ------- 0cd417b Reworded the built-in web server articles for Symfony 3.3
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 3.3: (40 commits) [#8273] fix bundle registration code [#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst [#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo ...
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 3.4: (42 commits) [#8273] fix bundle registration code [#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [#8269] minor rewording [Console] Commands auto-registration is deprecated [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst 75D6 [#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8270.
The current scenario for Symfony 3.3 is the worst possible: we don't have the web server by default (like in 3.2) ... and it's not easy to install it (like in 3.3+Flex or 4.0). That's why I propose to add a link in the main
setup.rstarticle to the full explanation about installing and enabling the bundle.In 4.0, we can remove that link and simply say: run
symfony require web-serverand then, execute./bin/console server:run.