-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update upload_file.rst #7981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update upload_file.rst #7981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
suggested changes
Jul 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that PR! Apart a minor comment, this looks good.
if ($fileName = $entity->getBrochure()) { | ||
$entity->setBrochure(new File($this->uploader->getTargetDir().'/'.$fileName)); | ||
$this->fileName = $entity->getBrochure() | ||
if ($this->fileName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted.
Thank you @rumours86. |
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #7981). Discussion ---------- Update upload_file.rst If you edit an existing product with an attached file and do not fill in the fields for the file, after saving the field with the file is reset Commits ------- d015048 Update upload_file.rst
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 2.7: [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo Update the setfacl description. Update associations.rst Update proxy_examples.rst Fixed logger processor example
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 2.8: (25 commits) [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typ 8000 o Update the setfacl description. Update events.rst Fixed a minor syntax issue Update phpunit_bridge.rst First parameter to uniqid must be a string fix #8321 minor changes in Serializer Component Update filesystem.rst Update associations.rst Update proxy_examples.rst ...
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 3.3: (40 commits) [#8273] fix bundle registration code [#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst [#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst Create validation_group_service_resolver.rst [#8290] fix minor typo ...
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
* 3.4: (42 commits) [#8273] fix bundle registration code [#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [#8269] minor rewording [Console] Commands auto-registration is deprecated [#8231] fix reStructuredText syntax Specified import order of config files [#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst [#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Sug
2CF0
gestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you edit an existing product with an attached file and do not fill in the fields for the file, after saving the field with the file is reset