8000 Update upload_file.rst by rumours86 · Pull Request #7981 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Update upload_file.rst #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update upload_file.rst #7981

wants to merge 1 commit into from

Conversation

rumours86
Copy link
Contributor

If you edit an existing product with an attached file and do not fill in the fields for the file, after saving the field with the file is reset

Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR! Apart a minor comment, this looks good.

if ($fileName = $entity->getBrochure()) {
$entity->setBrochure(new File($this->uploader->getTargetDir().'/'.$fileName));
$this->fileName = $entity->getBrochure()
if ($this->fileName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted.

@HeahDude HeahDude added this to the 2.7 milestone Jul 29, 2017
@xabbuh
Copy link
Member
xabbuh commented Sep 3, 2017

Thank you @rumours86.

xabbuh added a commit that referenced this pull request Sep 3, 2017
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #7981).

Discussion
----------

Update upload_file.rst

If you edit an existing product with an attached file and do not fill in the fields for the file, after saving the field with the file is reset

Commits
-------

d015048 Update upload_file.rst
xabbuh added a commit that referenced this pull request Sep 3, 2017
@xabbuh xabbuh closed this Sep 3, 2017
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 2.7:
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typo
  Update the setfacl description.
  Update associations.rst
  Update proxy_examples.rst
  Fixed logger processor example
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 2.8: (25 commits)
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typ
8000
o
  Update the setfacl description.
  Update events.rst
  Fixed a minor syntax issue
  Update phpunit_bridge.rst
  First parameter to uniqid must be a string
  fix #8321 minor changes in Serializer Component
  Update filesystem.rst
  Update associations.rst
  Update proxy_examples.rst
  ...
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 3.3: (40 commits)
  [#8273] fix bundle registration code
  [#8273] minor rewording
  Reworded the built-in web server articles for Symfony 3.3
  fix diff code block highlighting
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Update usage.rst
  Update doctrine.rst
  Update usage.rst
  [#8260] add missing redirection map entry
  Delete use_virtuals_forms.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  Create validation_group_service_resolver.rst
  [#8290] fix minor typo
  ...
xabbuh added a commit that referenced this pull request Sep 3, 2017
* 3.4: (42 commits)
  [#8273] fix bundle registration code
  [#8273] minor rewording
  Reworded the built-in web server articles for Symfony 3.3
  fix diff code block highlighting
  [#8269] minor rewording
  [Console] Commands auto-registration is deprecated
  [#8231] fix reStructuredText syntax
  Specified import order of config files
  [#7981] revert some changes
  Update upload_file.rst
  Update usage.rst
  Update doctrine.rst
  Update usage.rst
  [#8260] add missing redirection map entry
  Delete use_virtuals_forms.rst
  Added a missing redirection
  Update validation_group_service_resolver.rst
  Update redirection_map
  Update button_based_validation.rst
  Delete group_service_resolver.rst
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0