8000 2.3 only: Some more minor fixes by bicpi · Pull Request #3208 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
< 8000 div class="gh-header-show ">

2.3 only: Some more minor fixes #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2013
Merged

2.3 only: Some more minor fixes #3208

merged 3 commits into from
Nov 27, 2013

Conversation

bicpi
Copy link
Contributor
@bicpi bicpi commented Nov 19, 2013
Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets -

This is the equivalent of #3207 for 2.3.

I hope it is correct to remove the = in - [setRequest, ['@?request=']], couldn't find anything in the docs metioning this special syntax.

wouterj
wouterj reviewed Nov 19, 2013
View reviewed changes
cookbook/service_container/scopes.rst
@@ -149,7 +149,7 @@ your code. This should also be taken into account when declaring your service:
greeting_card_manager:
class: Acme\HelloBundle\Mail\GreetingCardManager
calls:
- [setRequest, ['@?request=']]
- [setRequest, ['@?request']]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect. It turns off strict mode #1707

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll revert this change.

weaverryan added a commit that referenced this pull request Nov 27, 2013
@weaverryan
Merge pull request #3208 from bicpi/more_fixes_2_3
e8d19b8 
2.3 only: Some more minor fixes
@weaverryan weaverryan merged commit e8d19b8 into symfony:2.3 Nov 27, 2013
@bicpi bicpi deleted the more_fixes_2_3 branch January 5, 2014 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bicpi @wouterj @weaverryan
0