10000 2.3 only: Some more minor fixes by bicpi · Pull Request #3208 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

2.3 only: Some more minor fixes #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2013
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Minor fixes: Typos, Formatting, code, YAML code block
  • Loading branch information
bicpi committed Nov 19, 2013
commit af764d7dc323bd305e46d33841b4343bd2072ea5
8 changes: 4 additions & 4 deletions cookbook/service_container/scopes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ you have three ways to deal with it:
* Use setter injection if the dependency is "synchronized"; this is the
recommended way and the best solution for the ``request`` instance as it is
synchronized with the ``request`` scope (see
:ref:`using-synchronized-service`).
:ref:`using-synchronized-service`);

* Put your service in the same scope as the dependency (or a narrower one). If
you depend on the ``request`` service, this means putting your new service
Expand All @@ -89,7 +89,7 @@ you have three ways to deal with it:
* Pass the entire container to your service and retrieve your dependency from
the container each time you need it to be sure you have the right instance
-- your service can live in the default ``container`` scope (see
10000 :ref:`passing-container`);
:ref:`passing-container`).

Each scenario is detailed in the following sections.

Expand Down Expand Up @@ -149,7 +149,7 @@ your code. This should also be taken into account when declaring your service:
greeting_card_manager:
class: Acme\HelloBundle\Mail\GreetingCardManager
calls:
- [setRequest, ['@?request=']]
- [setRequest, ['@?request']]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect. It turns off strict mode #1707

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll revert this change.


.. code-block:: xml

Expand Down Expand Up @@ -230,7 +230,7 @@ Changing the scope of a service should be done in its definition:
greeting_card_manager:
class: Acme\HelloBundle\Mail\GreetingCardManager
scope: request
arguments: [@request]
arguments: ["@request"]

.. code-block:: xml

Expand Down
2 changes: 1 addition & 1 deletion cookbook/templating/namespaced_paths.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ called ``sidebar.twig`` in that directory, you can use it easily:

.. code-block:: jinja

{% include '@foo_bar/side.bar.twig` %}
{% include '@foo_bar/side.bar.twig' %}
0