10000 Some more minor fixes: Typos, Formatting, broken code block, logic by bicpi · Pull Request #3207 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Some more minor fixes: Typos, Formatting, broken code block, logic #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2013
Merged

Some more minor fixes: Typos, Formatting, broken code block, logic #3207

merged 3 commits into from
Nov 27, 2013

Conversation

bicpi
Copy link
Contributor
@bicpi bicpi commented Nov 19, 2013
Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets -

Some more minor fixes.

I found that some YAML code block were broken (no line numbers; no highlighting) and all of them contained a line with arguments: [@MyService]. As all the other blocks are using arguments: ["@MyService"] (with double quotes) I hope this PR fixes this issue.

@bicpi bicpi mentioned this pull request Nov 19, 2013
Merged
@wouterj
Copy link
Member
wouterj commented Nov 19, 2013

As all the other blocks are using arguments: ["@myservice"](with double quotes) I hope this PR fixes this issue.

Yes, that's the problem. See also #1886

wouterj
wouterj reviewed Nov 19, 2013
View reviewed changes
cookbook/configuration/pdo_session_storage.rst
@@ -16,7 +16,7 @@ configuration format of your choice):

.. versionadded:: 2.1
In Symfony2.1 the class and namespace are slightly modified. You can now
find the session storage classes in the `Session\\Storage` namespace:
find the session storage classes in the ``Session\\Storage`` namespace:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove double backslash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the second backslash is not rendered in the docs and due to the recent changes at https://github.com/symfony/symfony-docs/pull/3199/files#diff-61123442647c483b4b656fb83927bb45R89 i thought this is some escaping. What's the right way?

@weaverryan weaverryan merged commit 4c14bdb into symfony:2.2 Nov 27, 2013
@bicpi bicpi deleted the more_fixes branch January 5, 2014 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bicpi @wouterj @weaverryan
0