Validator uninitialized handling (edit: branch created from false source branch) #14375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Reword wrong sentence cc @nicolas-grekas Commits ------- 767f90d Reword wrong sentence
* 4.4: Reword wrong sentence
* 5.1: Reword wrong sentence
(cherry picked from commit 42e156e)
* 5.1: New DI configuration syntax (PHP) instead of "legacy"
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Missed cleanup in fluent migration Commits ------- 1a9c48e Missed cleanup in fluent migration
* 4.4: Missed cleanup in fluent migration
* 5.1: User service() instead of ref() Missed cleanup in fluent migration
This PR was squashed before being merged into the master branch. Discussion ---------- Translatable objects Goal: Add docs for translatable objects. Feature: symfony/symfony#37670 Fixes #14145 Unsure how in-depth the docs should go. Open to feedback and collaboration. Commits ------- a2ad274 Translatable objects
…s6o9) This PR was squashed before being merged into the master branch. Discussion ---------- [Mailer] Added documentation for Sendinblue bridge <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- a1e19e2 [Mailer] Added documentation for Sendinblue bridge
* 3.4: Add missing `->end()` method call
* 4.4: Add missing `->end()` method call
* 5.1: Add missing `->end()` method call
This PR was merged into the 4.4 branch. Discussion ---------- Improve doc about log channel and env Hi On 3.4 there was such info which is important IMO ref: https://symfony.com/doc/3.4/logging/channels_handlers.html but on 4.4+, this info is missing (i do not know if deliberate or mistake) Maybe related to Slack discussion https://symfony-devs.slack.com/archives/C3EQ7S3MJ/p1597377730129600 Commits ------- a4aa344 Improve doc about log channel and env
* 4.4: Reword Improve doc about log channel and env
* 5.1: Reword Improve doc about log channel and env
* 5.1: Updated caution message
This PR was merged into the 5.1 branch. Discussion ---------- [lock] various fixes <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Commits ------- f4f5eb9 Various fixes
* 5.1: Various fixes
This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- Fix wording and add missing wording <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- b9b89c0 Fix wording and add missing wording
* 4.4: Fix wording and add missing wording
* 5.1: Fix wording and add missing wording
This PR was merged into the 4.4 branch. Discussion ---------- [lock] Add documentation about serializing lock Commits ------- 81316ee Add documentation about serializing lock
* 4.4: Add documentation about serializing lock
* 5.1: Add documentation about serializing lock
An explanation for the handling of uninitialized typed properties (introduced with PHP 7.4) was added.
javiereguiluz
added a commit
that referenced
this pull request
Jan 8, 2021
…g (SpiGAndromeda) This PR was submitted for the 3.4 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [Validator] PHP 7.4 uninitialized typed property handling The Validator component is able to handle uninitialized properties since this [PR](symfony/symfony@1edecf7) was merged. However, the behavior (null usage) is not documented in the symfony docs. P.S. PR [14375](#14375) was closed due to wrong source branch. Commits ------- 645a4d8 [Validator] PHP 7.4 uninitialized typed property handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Validator component is able to handle uninitialized properties since this PR was merged.
However, the behavior (null usage) is not documented in the symfony docs.