8000 Improve doc about log channel and env by noniagriconomie · Pull Request #14070 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Improve doc about log channel and env #14070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Improve doc about log channel and env #14070

merged 1 commit into from
Sep 25, 2020

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Aug 14, 2020 •
edited
Loading

Hi

On 3.4 there was such info which is important IMO
ref: https://symfony.com/doc/3.4/logging/channels_handlers.html

but on 4.4+, this info is missing (i do not know if deliberate or mistake)

Maybe related to Slack discussion https://symfony-devs.slack.com/archives/C3EQ7S3MJ/p1597377730129600

@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 25, 2020
@javiereguiluz javiereguiluz merged commit 1989ba9 into symfony:4.4 Sep 25, 2020
@javiereguiluz
Copy link
Member

Antoine, thanks for this contribution. However, we found the original text a bit repetitive, so instead of mentioning both file paths, we added a mention to "configuration environments" and a link to learn more about them.

@noniagriconomie noniagriconomie deleted the patch-6 branch September 25, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Logger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@noniagriconomie @javiereguiluz @maxhelias @carsonbot
0