8000 New DI configuration syntax (PHP) instead of "legacy" by a-menshchikov · Pull Request #14274 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

New DI configuration syntax (PHP) instead of "legacy" #14274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

New DI configuration syntax (PHP) instead of "legacy" #14274

wants to merge 0 commits into from

Conversation

a-menshchikov
Copy link
Contributor

"Legacy" syntax rewrote to new.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 24, 2020
@javiereguiluz javiereguiluz changed the base branch from master to 4.4 September 24, 2020 14:22
@javiereguiluz
Copy link
Member

@a-menshchikov thanks a lot for this contribution! I wanted to merge it in 4.4 branch and up ... but the tool we use to merge things failed ... and closed the issue and removed your commits !!!!!!

I'm really sorry. Do you still have this pull request in your local machine? If you do, can you please try to create a new pull request? (and hopefully rebase it to 4.4 branch, but it's OK if you don't do that). Thanks a lot and I'm sorry for this.

@javiereguiluz
Copy link
Member

Your commit is here: 42e156e. but it says that: "This commit does not belong to any branch on this repository". I don't understand what happened exactly.

@a-menshchikov
Copy link
Contributor Author

@javiereguiluz I have this pull request on local machine, but I doubt it should be rebased to 4.4.
service function that was mentioned in session/database.rst doesn't exists in 4.4 and was introduced in 5.1 (it replaced ref function that was deprecated). Maybe this PR should be rebased to 5.1?

Or I can rebase it to 4.4, but you should replace ref by service before merge it into 5.1.

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Sep 24, 2020
@javiereguiluz
minor symfony#14274 New DI configuration syntax (PHP) instead of "leg…
1e556bf 
…acy" (a-menshchikov)

This PR was merged into the master branch.

Discussion
----------

New DI configuration syntax (PHP) instead of "legacy"

"Legacy" syntax rewrote to new.

Commits
-------

42e156e New DI configuration syntax (PHP) instead of "legacy"
@javiereguiluz
Copy link
Member

OK, 5.1 would be great too! Thanks 🙏

@a-menshchikov a-menshchikov deleted the new_di_php_syntax branch September 24, 2020 14:45
@a-menshchikov a-menshchikov mentioned this pull request Sep 24, 2020
Merged
javiereguiluz added a commit that referenced this pull request Sep 24, 2020
@javiereguiluz
minor #14279 New DI configuration syntax (PHP) instead of "legacy" (a…
52bf1af 
…-menshchikov)

This PR was merged into the 5.1 branch.

Discussion
----------

New DI configuration syntax (PHP) instead of "legacy"

Remake of #14274

Commits
-------

7db3301 New DI configuration syntax (PHP) instead of "legacy"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@a-menshchikov @javiereguiluz @wouterj @carsonbot
0