8000 [Workflow] minor doc improvement by noniagriconomie · Pull Request #11845 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] minor doc improvement #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2019
Merged

[Workflow] minor doc improvement #11845

merged 1 commit into from
Aug 2, 2019

Conversation

noniagriconomie
Copy link
Contributor

Hi, IMO using a good named var is better

it is a better understanding after reading the first part describing a pull request configuration

@noniagriconomie noniagriconomie changed the title [Workflow] doc improvement [Workflow] minor doc improvement Jun 28, 2019
@noniagriconomie noniagriconomie mentioned this pull request Jul 4, 2019
Merged
OskarStark
OskarStark approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 😄

@OskarStark OskarStark requested a review from javiereguiluz July 23, 2019 07:21
@OskarStark OskarStark added this to the 4.3 milestone Aug 2, 2019
@OskarStark
Copy link
Contributor

Thank you Antoine.

@OskarStark OskarStark merged commit 7d88725 into symfony:4.3 Aug 2, 2019
OskarStark added a commit that referenced this pull request Aug 2, 2019
@OskarStark
minor #11845 [Workflow] minor doc improvement (noniagriconomie)
35bdc5f 
This PR was merged into the 4.3 branch.

Discussion
----------

[Workflow] minor doc improvement

Hi, IMO using a good named var is better

it is a better understanding after reading the first part describing a pull request configuration

Commits
-------

7d88725 Update introduction.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@maxhelias maxhelias maxhelias approved these changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@noniagriconomie @OskarStark @maxhelias @carsonbot
0