8000 [Workflow] improve Workflow component documentation by noniagriconomie · Pull Request #11835 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Workflow] improve Workflow component documentation #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

[Workflow] improve Workflow component documentation #11835

merged 1 commit into from
Jul 18, 2019

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Jun 27, 2019 •
edited
Loading

Hi

Here is a minor improvement of this part of the doc.

  • do not use deprecated marking store
  • use the right wording: place and transition instead of state and action
  • rewrite some vars name

Thx

OskarStark
OskarStark reviewed Jun 28, 2019
View reviewed changes
@noniagriconomie
Copy link
Contributor Author
noniagriconomie commented Jul 4, 2019 •
edited
Loading

@OskarStark any change to do?
can be merged with #11845? (2 PRs as i propose PR from sf doc page)

Also, can you take a look at #11580 ?

Many thanks

OskarStark
OskarStark approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from my side.
I will have a look at the other PR 👍🏻

@OskarStark
Copy link
Contributor

@javiereguiluz is this the right target branch? 🤔

@wouterj wouterj merged commit e0d6c11 into symfony:4.3 Jul 18, 2019
wouterj added a commit that referenced this pull request Jul 18, 2019
@wouterj
feature #11835 [Workflow] improve Workflow component documentation (n…
a02a790 
…oniagriconomie)

This PR was merged into the 4.3 branch.

Discussion
----------

[Workflow] improve Workflow component documentation

Hi

Here is a minor improvement of this part of the doc.

- do not use deprecated marking store
- use the right wording: place and transition instead of state and action
- rewrite some vars name

Thx

Commits
-------

e0d6c11 Update workflow.rst
@wouterj
Copy link
Member
wouterj commented Jul 18, 2019

Hi @noniagriconomie! Thanks for your PR, all changes make 100% sense to me.

@OskarStark the deprecation is done in 4.3. So I've merged it directly into 4.3 (the current target branch of this PR). No need to do complex git stuff for the other changes (most of the users will read the current version of the docs).

@noniagriconomie
Copy link
Contributor Author

@wouterj thanks for merging

can you please take a look to #11580 as well?
very similar: workflow config for 4.3

cheers

@noniagriconomie noniagriconomie deleted the patch-4 branch July 18, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Needs Review Workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noniagriconomie @OskarStark @wouterj @javiereguiluz @carsonbot
0