minor #11845 [Workflow] minor doc improvement (noniagriconomie)

OskarStark · OskarStark · commit 35bdc5f796f8 · 2019-08-02T08:21:26.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- [Workflow] minor doc improvement Hi, IMO using a good named var is better it is a better understanding after reading the first part describing a pull request configuration Commits ------- 7d88725 Update introduction.rst
diff --git a/workflow/introduction.rst b/workflow/introduction.rst
@@ -239,6 +239,7 @@ In a Symfony application using the
 you can get this state machine by injecting the Workflow registry service::
 
     // ...
+    use App\Entity\PullRequest;
     use Symfony\Component\Workflow\Registry;
 
     class SomeService
@@ -250,10 +251,10 @@ you can get this state machine by injecting the Workflow registry service::
             $this->workflows = $workflows;
         }
 
-        public function someMethod($subject)
+        public function someMethod(PullRequest $pullRequest)
         {
-            $stateMachine = $this->workflows->get($subject, 'pull_request');
-            $stateMachine->apply($subject, 'wait_for_review');
+            $stateMachine = $this->workflows->get($pullRequest, 'pull_request');
+            $stateMachine->apply($pullRequest, 'wait_for_review');
             // ...
         }
 
@@ -267,6 +268,7 @@ or ``state_machine.pull_request`` respectively in your service definitions
 to access the proper service::
 
     // ...
+    use App\Entity\PullRequest;
     use Symfony\Component\Workflow\StateMachine;
 
     class SomeService
@@ -278,9 +280,9 @@ to access the proper service::
             $this->stateMachine = $stateMachine;
         }
 
-        public function someMethod($subject)
+        public function someMethod(PullRequest $pullRequest)
         {
-            $this->stateMachine->apply($subject, 'wait_for_review', [
+            $this->stateMachine->apply($pullRequest, 'wait_for_review', [
                 'log_comment' => 'My logging comment for the wait for review transition.',
             ]);
             // ...
