8000 be keen to newcomers by OskarStark · Pull Request #11044 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

be keen to newcomers #11044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

be keen to newcomers #11044

wants to merge 3 commits into from

Conversation

OskarStark
Copy link
Contributor
@OskarStark OskarStark commented Feb 22, 2019 •
edited
Loading

Do not use easy, easily and simply

This is a follow-up PR of #11036

@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 22, 2019
@OskarStark OskarStark force-pushed the be-keen-to-newcomers branch 3 times, most recently from 99303b7 to 06206bc Compare February 23, 2019 11:39
OskarStark
OskarStark commented Feb 23, 2019
View reviewed changes
OskarStark
OskarStark commented Feb 23, 2019
View reviewed changes
sstok
sstok reviewed Feb 23, 2019
View reviewed changes
8000
sstok
sstok reviewed Feb 23, 2019
View reviewed changes
@OskarStark
Copy link
Contributor Author

Thank you @sstok I applied your comments 👍

linaori
linaori suggested changes Feb 23, 2019
View reviewed changes
Copy link
Contributor
@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, great improvement! Thanks!

fancyweb
fancyweb reviewed Feb 23, 2019
View reviewed changes
HeahDude
HeahDude reviewed Feb 23, 2019
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that PR <3

@OskarStark
Copy link
Contributor Author

Thank you @fancyweb, @dbu, @linaori and @HeahDude I applied your comments in the latest commit 👍

sstok
sstok reviewed Feb 24, 2019
View reviewed changes
@OskarStark
Copy link
Contributor Author

And if you like you can also check the previous PR again, which doesn't get so much attention: #11036

dbu
dbu approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor
@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this effort.

i think i recognize some of those from #10535. i was rather confused until i realized that this PR goes against 3.4. maybe we should have done that in #10535 already, this might be a bit of a mess to merge to the newer versions. if the doc maintainers are okay to handle it, great! seems that #11036 already went into 3.4 so we should probably do the effort to be consistent.

i suggested some tweaks.

67E6
@OskarStark
Copy link
Contributor Author

Thanks @dbu, I applied your comments

@OskarStark
Copy link
Contributor Author

After a second round of review I will squash my commits

javiereguiluz added a commit that referenced this pull request Feb 26, 2019
@javiereguiluz
minor #11044 be keen to newcomers (OskarStark)
a58731c 
This PR was squashed before being merged into the 3.4 branch (closes #11044).

Discussion
----------

be keen to newcomers

Do not use **easy**, **easily** and **simply**

This is a follow-up PR of #11036

Commits
-------

979274b be keen to newcomers
@javiereguiluz
Copy link
Member
javiereguiluz commented Feb 26, 2019 •
edited
Loading

Thank you Oskar. Your work here is warmly appreciated ❤️

Note: we squashed the commits while merging.

@OskarStark OskarStark deleted the be-keen-to-newcomers branch February 27, 2019 07:01
@OskarStark OskarStark mentioned this pull request Feb 27, 2019
Closed
@OskarStark
Copy link
Contributor Author

Thank you for merging this @javiereguiluz ❤️

As we talked via slack, following PR's of this kind should be applied against master, so here I am with another one: #11063

At all reviewers, thank you for your time and feedback and please review my next one with the same passion 😍

javiereguiluz added a commit that referenced this pull request Feb 28, 2019
@javiereguiluz
minor #11063 Be keen to newcomers (OskarStark)
ddbf08d 
This PR was squashed before being merged into the 4.2 branch (closes #11063).

Discussion
----------

Be keen to newcomers

Do not use **easy**, **easily** and **simply**

This is a follow-up PR of #11044

Commits
-------

04d727d Be keen to newcomers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstok sstok sstok left review comments

@linaori linaori linaori requested changes

@xabbuh xabbuh xabbuh left review comments

@fancyweb fancyweb fancyweb left review comments

@HeahDude HeahDude HeahDude left review comments

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
9 participants
@OskarStark @javiereguiluz @dbu @sstok @linaori @xabbuh @fancyweb @HeahDude @carsonbot
0