-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
be keen to newcomers #11036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
be keen to newcomers #11036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
915f639
to
a32eb51
Compare
cd62bb5
to
ece09bc
Compare
This PR is ready to review, it would grow too much I will open another following PR if this is done. |
ece09bc
to
6f30499
Compare
Thanks Oskar! I've merged this one to avoid having a too big and too difficult to merge pull request. We can merge PRs like this in the future to fix more issues. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 22, 2019
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 6f30499 be keen to newcomers
Closed
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 22, 2019
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11036 Commits ------- c008ee0 be keen to newcomers
joshtrichards
pushed a commit
to joshtrichards/symfony-finder
that referenced
this pull request
Apr 26, 2024
This PR was merged into the 3.4 branch. Discussion ---------- be keen to newcomers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11036 Commits ------- e54b10c be keen to newcomers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.