10000 applied comments · symfony/symfony-docs@c063b0e · GitHub
[go: up one dir, main page]

Skip to content

Commit c063b0e

Browse files
committed
applied comments
1 parent 026fd4e commit c063b0e

File tree

6 files changed

+9
-8
lines changed

6 files changed

+9
-8
lines changed

best_practices/controllers.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,9 @@ flexible::
208208
// ...
209209
}
210< 8000 code>210

211-
The point is this: the ParamConverter shortcut is great for simple situations.
212-
But you shouldn't forget that querying for entities directly is not to difficult.
211+
The point is this: the ParamConverter shortcut is great for most situations.
212+
However, there is nothing wrong with querying for entities directly if the
213+
ParamConverter would get complicated.
213214

214215
Pre and Post Hooks
215216
------------------

best_practices/security.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ need to repeat the expression code using Twig syntax:
166166
<a href=""> ... </a>
167167
{% endif %}
168168

169-
A better solution - if your logic is simple enough - is to add a new method
169+
A good solution - if your logic is simple enough - can be to add a new method
170170
to the ``Post`` entity that checks if a given user is its author::
171171

172172
// src/AppBundle/Entity/Post.php

create_framework/http_foundation.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ As you can see for yourself, the simple code we had written first is not that
5252
simple anymore if we want to avoid PHP warnings/notices and make the code
5353
more secure.
5454

55-
Beyond security, this code is quite hard to test. Even if there is not
55+
Beyond security, this code can be complex to test. Even if there is not
5656
much to test, it strikes me that writing unit tests for the simplest possible
5757
snippet of PHP code is not natural and feels ugly. Here is a tentative PHPUnit
5858
unit test for the above code::

email/testing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ SwiftmailerBundle, which leverages the power of the `Swift Mailer`_ library.
1010
To functionally test that an email was sent, and even assert the email subject,
1111
content or any other headers, you can use :doc:`the Symfony Profiler </profiler>`.
1212

13-
Start with an controller action that sends an email::
13+
Start with a controller action that sends an email::
1414

1515
public function sendEmailAction($name, \Swift_Mailer $mailer)
1616
{

form/direct_submit.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
How to Use the submit() Function to Handle Form Submissions
55
===========================================================
66

7-
Handle the form submission via the ``handleRequest()`` method::
7+
Handle the form submission with the ``handleRequest()`` method::
88

99
use Symfony\Component\HttpFoundation\Request;
1010
// ...

forms.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ Forms
1010
Do you prefer video tutorials? Check out the `Symfony Forms screencast series`_.
1111

1212
Dealing with HTML forms is one of the most common - and challenging - tasks for
13-
a web developer. Symfony integrates a Form component that makes dealing with
14-
forms straightforward. In this article, you'll build a complex form from the ground up,
13+
a web developer. Symfony integrates a Form component that helps you dealing
14+
with forms. In this article, you'll build a complex form from the ground up,
1515
learning the most important features of the form library along the way.
1616

1717
.. note::

0 commit comments

Comments
 (0)
0