8000 Change example in "Page Creation" · Issue #3576 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Change example in "Page Creation" #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Feb 13, 2014 · 1 comment
Closed

Change example in "Page Creation" #3576

wouterj opened this issue Feb 13, 2014 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them.

Comments

@wouterj
Copy link
Member
wouterj commented Feb 13, 2014

As you can see in #3572, the "Page Creation" docs is a bit confusing.

The problem is that the AcmeDemoBundle has a "hello world demo" using the URL /demo/hello/World. That article is creating exactly the same controller bound to /hello/World.

We should consider changing the example in the page creation docs to another docs, which isn't included in the AcmeDemoBundle.
@wouterj wouterj mentioned this issue Feb 13, 2014
Closed
@javiereguiluz javiereguiluz mentioned this issue May 29, 2014
Merged
weaverryan added a commit that referenced this issue Aug 16, 2014
@weaverryan
feature #3888 Updated the example used to explain page creation (javi…
cafea43 
…ereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Updated the example used to explain page creation

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #3576

To avoid confusions with the AcmeDemoBundle, this chapter now uses a "Random Number" example instead of the classic "Hello World".

Commits
-------

1350e6c Added a note for users with an existing AcmeDemoBundle
1c01b49 Replaced "AcmeWebsiteBundle" by "AcmeDemoBundle"
2345a0e Reworded the beginning of one section
575bc9a Replaced the "Hello World" example to avoid confusion with AcmeDemoBundle
@weaverryan
Copy link
Member

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @wouterj
0