8000 Update page_creation.rst by mjankiewicz · Pull Request #3572 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Update page_creation.rst #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update page_creation.rst #3572

wants to merge 1 commit into from

Conversation

mjankiewicz
Copy link

No description provided.

@@ -70,7 +70,7 @@ by going to the following URL:

.. code-block:: text

http://localhost/app_dev.php/hello/Symfony
http://localhost/app_dev.php/demo/hello/Symfony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not right. The route path is /hello/{name} not /demo/hello/{name}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjankiewicz
Copy link
Author

Are you sure ? :) I'm reading now documentation and prepare application (with AcmeBundle). In my case an link to "hello..." is : http://sf2.loc/app_dev.php/demo/hello/World (Acme Bundle) but maybe I think wrong.

@wouterj
Copy link
Member
wouterj commented Feb 12, 2014

Nice one, @mjankiewicz ! This error is here for a really long time and you are the first one who spotted it (well, at last the first one who wanted to fix it!). Thank you!

Btw, you don't have to create a new PR, but fixes should be based on the 2.3 branch and not the 2.4 branch. This is an inconvinience of the doc "edit" button...

@xabbuh
Copy link
Member
xabbuh commented Feb 12, 2014

Well, do we refer to the standard edition or to the example in this chapter? If we want to be consistent with the AcmeDemoBundle from the standard edition, the routing example also needs to be updated.

@wouterj
Copy link
Member
wouterj commented Feb 13, 2014

Hmm, indeed. Even I read the docs wrong.

@mjankiewicz that chapter is creating a new controller which is bound to /hello/World. That article is not talking about the demo from the AcmeDemoBundle. I think that's very confusing, so I created an issue to change it to another example: #3576

@wouterj wouterj closed this Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0