Updated the example used to explain page creation #3888
Conversation
| you're finished, the user will be able to get a personal greeting (e.g. "Hello Symfony") | ||
| by going to the following URL: | ||
| Instead of building the classic "Hello World!" application, this chapter develops | ||
| an appllication that generates random numbers . When you're finished, the user |
There was a problem hiding this comment.
It's a bit strange to start a section with "Instead". Let's just say "In this chapter, you'll develop an application that can generate random numbers. When you're [...]"
|
Create example! |
| by going to the following URL: | ||
| In this chapter, you'll develop an application that can generate random numbers. | ||
| When you're finished, the user will be able to get a random number between ``1`` | ||
| and the upper limit set with the URL: |
There was a problem hiding this comment.
Isn't [...] set by the URL correct?
|
@xabbuh you are absolutely right! |
|
I like it! But, won't using |
|
That's a good point, Ryan. Is there a better name to use? Would be great to have one unique name throughout the docs. |
|
:) I would like to call it |
|
Well, to be honest. I don't see the extra value of having the same bundle for all documentation. Using different bundles means we can use different examples and using more examples gives people a better overview of what Symfony is capable of. But let's move that discussion to somewhere else :) |
|
Actually, +1 to that Wouter |
|
After reading this discussion, I'm a bit confused about the bundle name. So please, tell me which name do you want to use for this example and I'll change it:
|
|
Let's use AcmeDemoBundle here (including the "You may already have an AcmeDemoBundle, etc etc" proposal of Ryan if you think it's usefull). We can discuss later if we want to include the vendor name or not, etc. |
|
+1 |
|
ping @weaverryan |
|
Thanks everyone! |
…ereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Updated the example used to explain page creation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #3576 To avoid confusions with the AcmeDemoBundle, this chapter now uses a "Random Number" example instead of the classic "Hello World". Commits ------- 1350e6c Added a note for users with an existing AcmeDemoBundle 1c01b49 Replaced "AcmeWebsiteBundle" by "AcmeDemoBundle" 2345a0e Reworded the beginning of one section 575bc9a Replaced the "Hello World" example to avoid confusion with AcmeDemoBundle
We're just showing what *is* actually there, not telling them to change anything.
* 2.3: (35 commits) use relative path to page fix xml to specify a method replaced old way of specifying http method by the new one Fixing a mistake Fix use mistakes. [#3944] Tiny addition to mention multiple connections Update dbal.rst [#3888] Changing base template title back [Components] consistent & complete config examples Fixed typos Added link to JSFiddle example some minor improvements describe the usage of the RegisterListenersPass Update deployment-tools.rst Rewrote Extension & Configuration docs add order of translation formats Fix class name in ConsoleTerminateListener example [Book] consistent and complete config examples added Github teams for the core team [book][cache][tip] added cache annotations. ...
* 2.4: (38 commits) use relative path to page fix xml to specify a method replaced old way of specifying http method by the new one Fixing a mistake Fix use mistakes. [#3944] Tiny addition to mention multiple connections Update dbal.rst [#3888] Changing base template title back [Components] consistent & complete config examples Check for api_key in request Update api_key_authentication.rst - POST Method Fixed typos Added link to JSFiddle example some minor improvements describe the usage of the RegisterListenersPass Update deployment-tools.rst Rewrote Extension & Configuration docs add order of translation formats Fix class name in ConsoleTerminateListener example Fixed the code snippets for the expression language functions ...
* 2.5: (39 commits) use relative path to page fix xml to specify a method replaced old way of specifying http method by the new one Fixing a mistake Fix use mistakes. [#3944] Tiny addition to mention multiple connections Update dbal.rst [#3888] Changing base template title back [Components] consistent & complete config examples Check for api_key in request Update api_key_authentication.rst - POST Method Fixed typos Fixed typos Added link to JSFiddle example some minor improvements describe the usage of the RegisterListenersPass Update deployment-tools.rst Rewrote Extension & Configuration docs add order of translation formats Fix class name in ConsoleTerminateListener example ...
see #4361 |
To avoid confusions with the AcmeDemoBundle, this chapter now uses a "Random Number" example instead of the classic "Hello World".