8000 [Config] FIxed Loader::import() by jakzal · Pull Request #7987 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] FIxed Loader::import() #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Config] FIxed Loader::import() #7987

wants to merge 2 commits into from

Conversation

jakzal
Copy link
Contributor
@jakzal jakzal commented May 9, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets fixes #7965, replaces #7983
License MIT
Doc PR -

@jakzal jakzal mentioned this pull request May 9, 2013
Closed
stof
stof reviewed May 9, 2013
View reviewed changes
src/Symfony/Component/Config/Tests/Loader/LoaderTest.php
public function testGetSetResolver()
{
$resolver = new LoaderResolver();
$resolver = $this->getMock('Symfony\Component\Config\Loader\LoaderResolver');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mock the interface instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

fabpot added a commit that referenced this pull request May 9, 2013
@fabpot
merged branch jakzal/loader-fix (PR #7987)
d2a542c 
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7987).

Discussion
----------

[Config] FIxed Loader::import()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | fixes #7965, replaces #7983
| License       | MIT
| Doc PR        | -

Commits
-------

984e56a [Config] Added a test case for Loader::import().
2f69860 [Config] Fixed Loader import
@fabpot
Copy link
Member
fabpot commented May 9, 2013

merged in 2.1, thanks.

@fabpot fabpot closed this May 9, 2013
@jakzal jakzal deleted the loader-fix branch May 10, 2013 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config Loader import problem
4 participants
@jakzal @fabpot @stof @Myke79
0