8000 Config Loader import problem · Issue #7965 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Config Loader import problem #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Myke79 opened this issue May 7, 2013 · 3 comments
Closed

Config Loader import problem #7965

Myke79 opened this issue May 7, 2013 · 3 comments
Labels
Bug Config

Comments

@Myke79
Copy link
Contributor
Myke79 commented May 7, 2013

I made a custom loader by extending the Loader class.
Then i run into a problem with the import() method, when I tried to import a controller with annotation type. It tried to load it with the PhpFileLoader().
I realize that the Symfony/Component/Config/Loader/Loader.php import method may need some fixing:

return $this->resolve($resource)->load($resource, $type);
into:
return $this->resolve($resource, $type)->load($resource, $type);

Until then i just override it, and now it works.
@stof
Copy link
Member
stof commented May 9, 2013

Can you send a pull request with your bugfix ?

@Myke79
Copy link
Contributor Author
Myke79 commented May 9, 2013

Pull request sent. (sorry i'm new on github)

@jakzal
Copy link
Contributor
jakzal commented May 9, 2013

re #7983

@Myke79 Myke79 mentioned this issue May 9, 2013
Closed
@jakzal jakzal mentioned this issue May 9, 2013
Closed
fabpot added a commit that referenced this issue May 9, 2013
@fabpot
merged branch jakzal/loader-fix (PR #7987)
d2a542c 
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7987).

Discussion
----------

[Config] FIxed Loader::import()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | fixes #7965, replaces #7983
| License       | MIT
| Doc PR        | -

Commits
-------

984e56a [Config] Added a test case for Loader::import().
2f69860 [Config] Fixed Loader import
@fabpot fabpot closed this as completed May 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Config] FIxed Loader::import() jakzal/symfony
4 participants
@fabpot @jakzal @stof @Myke79
0