[Config][Loader] missing type parameter on import #7983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Myke79 you should include the checklist as described in the Submitting a Patch - Make a pull request. |
|
ok sorry, im new to this |
|
Im not sure about two questions, but tell me if i need to do anything else. |
|
Can you add a test to avoid regression (the test should fail without your patch and pass with it) |
|
I understand what you asking, but I don't know how to do that. :( |
|
@Myke79 I'll write a test case for you. |
|
@jakzal thank you. |
|
Closing in favor of #7987 |
|
Thanks you! |
fabpot
added a commit
that referenced
this pull request
May 9, 2013
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7987). Discussion ---------- [Config] FIxed Loader::import() | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | fixes #7965, replaces #7983 | License | MIT | Doc PR | - Commits ------- 984e56a [Config] Added a test case for Loader::import(). 2f69860 [Config] Fixed Loader import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$type was missing inside the import() resolver call.