8000 [Validator] Add Catalan and Spanish translation for `Week` constraint by oriolvinals · Pull Request #58173 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add Catalan and Spanish translation for Week constraint #58173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

[Validator] Add Catalan and Spanish translation for Week constraint #58173

merged 1 commit into from
Sep 6, 2024

Conversation

oriolvinals
Copy link
Contributor
Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Adding translation in Catalan and Spanish for Week constraint

@carsonbot carsonbot added this to the 7.2 milestone Sep 4, 2024
javiereguiluz
javiereguiluz reviewed Sep 4, 2024
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Oriol! I left some minor suggestions. gràcies

@oriolvinals oriolvinals force-pushed the feature/catalan-spanish-translation-week-constraint branch from 6ca9b60 to 82e7772 Compare September 4, 2024 15:51
@OskarStark
Copy link
Contributor

It looks like your conmiter email address is not associated with your GitHub account, you may want to change that.

image

@oriolvinals oriolvinals force-pushed the feature/catalan-spanish-translation-week-constraint branch from 82e7772 to 571e1ed Compare September 5, 2024 07:35
@fabpot fabpot changed the base branch from 7.2 to 5.4 September 6, 2024 05:58
@fabpot fabpot force-pushed the feature/catalan-spanish-translation-week-constraint branch from 571e1ed to 28415a2 Compare September 6, 2024 05:58
@fabpot
Copy link
Member
fabpot commented Sep 6, 2024

Thank you @oriolvinals.

@fabpot fabpot merged commit af1c1a7 into symfony:5.4 Sep 6, 2024
9 of 10 checks passed
@fabpot fabpot modified the milestones: 7.2, 5.4 Sep 6, 2024
@oriolvinals oriolvinals deleted the feature/catalan-spanish-translation-week-constraint branch September 6, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@oriolvinals @OskarStark @fabpot @javiereguiluz @carsonbot
0