8000 [Validator] Improve `zh_TW` translation by pan93412 · Pull Request #58139 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Improve zh_TW translation #58139

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2024
Merged

[Validator] Improve zh_TW translation #58139

merged 1 commit into from
Sep 1, 2024

Conversation

pan93412
Copy link
Contributor
@pan93412 pan93412 commented Aug 31, 2024 •
edited
Loading
Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues N/A
License MIT

The original translation appears machine-generated, containing some unusual characters (壹).

Additionally, the missing translation has been completed.

@carsonbot carsonbot added this to the 7.2 milestone Aug 31, 2024
@pan93412 pan93412 force-pushed the validator/improve-zh-tw-l10n branch from dc9d7eb to 57f07b9 Compare August 31, 2024 19:22
@pan93412 pan93412 force-pushed the validator/improve-zh-tw-l10n branch from 9b96c6b to bc0486c Compare August 31, 2024 19:33
@pan93412 pan93412 changed the title [Validator] Improve zh_TW translation [Validator] Improve zh_TW translation Aug 31, 2024
@pan93412 pan93412 force-pushed the validator/improve-zh-tw-l10n branch from bc0486c to 787ab0d Compare August 31, 2024 19:39
@pan93412 pan93412 requested a review from lumynou5 September 1, 2024 04:42
Crystal-RainSlide 8000
Crystal-RainSlide approved these changes Sep 1, 2024
View reviewed changes
Copy link
@Crystal-RainSlide Crystal-RainSlide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

lumynou5
lumynou5 approved these changes Sep 1, 2024
View reviewed changes
Copy link
@lumynou5 lumynou5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot fabpot modified the milestones: 7.2, 5.4 Sep 1, 2024
@fabpot fabpot changed the base branch from 7.2 to 5.4 September 1, 2024 10:44
@fabpot fabpot force-pushed the validator/improve-zh-tw-l10n branch from 0327adb to bda9b92 Compare September 1, 2024 10:44
@fabpot
Copy link
Member
fabpot commented Sep 1, 2024

Thank you @pan93412.

@fabpot fabpot merged commit 6896976 into symfony:5.4 Sep 1, 2024
5 checks passed
@pan93412 pan93412 deleted the validator/improve-zh-tw-l10n branch September 1, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crystal-RainSlide Crystal-RainSlide Crystal-RainSlide approved these changes

@lumynou5 lumynou5 lumynou5 approved these changes

@xabbuh xabbuh Awaiting requested revi 7566 ew from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
Status: Needs Review Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@pan93412 @fabpot @Crystal-RainSlide @lumynou5 @carsonbot
0