[FrameworkBundle] Deprecate not setting some options #51325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73c3fc6 to
b5bba1a
Compare
nicolas-grekas
approved these changes
Aug 10, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Aug 11, 2023
src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
Outdated
Show resolved
Hide resolved
b0f411e to
7f9998e
Compare
|
I addressed theremaining issues. |
|
Thank you @Jean-Beru. |
|
I think you can revert most of the changes in the tests in the 7.0 branch now that it has been merged. |
|
Help wanted for the cleanup on 7.0! |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2023
…daubois) This PR was merged into the 7.0 branch. Discussion ---------- [FrameworkBundle] Remove config deprecations | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Todo Follow-up of: - #51325 - #51357 Commits ------- 4fe6f5b [FrameworkBundle] Remove config deprecations
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates not setting 5 options in framework configuration to match the v7.0 recipe:
handle_all_throwableswhich isfalseby default and is set totrueby recipephp_errors.logwhich use$debugvalue by default and is set totrueby recipesession.cookie_secure(if session is enabled) which isnullby default and is set toautoby recipesession.cookie_samesite(if session is enabled) which isnullby default and is set tolaxby recipesession.handler_id(if session is enabled) which issession.handler.native_fileby default and is set tonullby recipe (could besession.handler.native_fileifframework.session.save_pathis set)See #51097.