[RFC] Shrink recipes for v7 #51097
Labels
Help wanted
Issues and PRs which are looking for volunteers to complete them.
RFC
RFC = Request For Comments (proposals about features that you want to be discussed)
Comments
|
Low-hanging fruit: symfony/recipes#1225 😇 |
This was referenced Aug 9, 2023
nicolas-grekas
added a commit
that referenced
this issue
Aug 17, 2023
…uid, validation) (Jean-Beru) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Deprecate not setting some options (uid, validation) | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Fix #51097 | License | MIT | Doc PR | This PR deprecates not setting 4 options in framework configuration to match the v7.0 recipe: * `uid.default_uuid_version` which is `6` by default and is set to `7` by recipe * `uid.time_based_uuid_version` which is `6` by default and is set to `7` by recipe * `validation.email_validation_mode` which is `null` by default and is set to `html5` by recipe See #51097. Commits ------- aa3fbc5 [FrameworkBundle] Deprecate not setting some options (uid, validation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over time, recipes grow in size. For example, the recipe for 6.2 added the
handle_all_throwablesoption to turn it on by default.It'd be great to shrink recipes by making v7 defaults to the values we have currently in the recipes.
Here is the current config file for framework-bundle v7:
https://github.com/symfony/recipes/blob/main/symfony/framework-bundle/7.0/config/packages/framework.yaml
Let's deprecate not setting all/most of those options and shrink the recipe.
Let's review the other recipes also as part of the same effort.
Feedback and Help Wanted for the implementations.
The text was updated successfully, but these errors were encountered: