[FrameworkBundle] Deprecate not setting some options (uid, validation) #51357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Aug 11, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php
Outdated
Show resolved
Hide resolved
| ->validate() | ||
| ->always(function (array $v): array { | ||
| if (empty($v['password_hashers'])) { | ||
| trigger_deprecation('symfony/framework-bundle', '6.4', 'Not setting the "security.password_hashers" config option is deprecated. It will default to "Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: auto" in 7.0.'); |
There was a problem hiding this comment.
I'm not sure about this deprecation. Default values for a prototyped array node are not merged with provided config. So as soon as any config file (or config prepended by a bundle) adds some other config for password hashers, the config for PasswordAuthenticatedUserInterface would be lost.
I'd suggest keeping that one in the recipe.
There was a problem hiding this comment.
They would be merged if we didn't call performNoDeepMerging, isn't it?
Why don't we perform deep merging BTW?
There was a problem hiding this comment.
Anyway, let's drop this, it's not needed to deprecate not setting this
There was a problem hiding this comment.
🤷 a5cfc22 "some bug fixes in DIC config classes"
There was a problem hiding this comment.
@nicolas-grekas no. deep merging is about the various configs received as input, not the defaults
d1c71de to
ab2faa1
Compare
nicolas-grekas
previously approved these changes
Aug 14, 2023
There are remaning deprecations, please fix them.
ab2faa1 to
878cda2
Compare
…tions (Jean-Beru) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Deprecate not setting some options | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | Fix symfony#51097 | License | MIT | Doc PR | This PR deprecates not setting 5 options in framework configuration to match the v7.0 recipe: * `handle_all_throwables` which is `false` by default and is set to `true` by recipe * `php_errors.log` which use `$debug` value by default and is set to `true` by recipe * `session.cookie_secure` (if session is enabled) which is `null` by default and is set to `auto` by recipe * `session.cookie_samesite` (if session is enabled) which is `null` by default and is set to `lax` by recipe * `session.handler_id` (if session is enabled) which is `session.handler.native_file` by default and is set to `null` by recipe (could be `session.handler.native_file` if `framework.session.save_path` is set) See symfony#51097. Commits ------- 7f9998e [FrameworkBundle] Deprecate not setting some options
878cda2 to
aa3fbc5
Compare
|
Thank you @Jean-Beru. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2023
…daubois) This PR was merged into the 7.0 branch. Discussion ---------- [FrameworkBundle] Remove config deprecations | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - | License | MIT | Doc PR | Todo Follow-up of: - #51325 - #51357 Commits ------- 4fe6f5b [FrameworkBundle] Remove config deprecations
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates not setting 4 options in framework configuration to match the v7.0 recipe:
uid.default_uuid_versionwhich is6by default and is set to7by recipeuid.time_based_uuid_versionwhich is6by default and is set to7by recipevalidation.email_validation_modewhich isnullby default and is set tohtml5by recipeSee #51097.