8000 [Lock] Add the void return type in Lock interfaces by stof · Pull Request #50090 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Lock] Add the void return type in Lock interfaces #50090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Lock] Add the void return type in Lock interfaces #50090

merged 1 commit into from
Apr 21, 2023

Conversation

stof
Copy link
Member
@stof stof commented Apr 21, 2023
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR n/a

Contributes to #47551

@stof stof requested a review from jderusse as a code owner April 21, 2023 11:09
@carsonbot carsonbot added this to the 6.3 milestone Apr 21, 2023
@fabpot
Copy link
Member
fabpot commented Apr 21, 2023

Thank you @stof.

@stof stof force-pushed the lock_return_types branch from 66dd1ad to c7eab24 Compare April 21, 2023 11:20
fabpot added a commit that referenced this pull request Apr 21, 2023
@fabpot
minor #50090 [Lock] Add the void return type in Lock interfaces (stof)
805f207 
This PR was merged into the 6.3 branch.

Discussion
----------

[Lock] Add the void return type in Lock interfaces

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | n/a

Contributes to #47551

Commits
-------

66dd1ad Add the void return type in Lock interfaces
@fabpot fabpot merged commit 9289fd8 into symfony:6.3 Apr 21, 2023
@stof stof deleted the lock_return_types branch April 21, 2023 11:26
@stof stof mentioned this pull request Apr 21, 2023
Merged
fabpot added a commit that referenced this pull request Apr 21, 2023
@fabpot
minor #50097 Fix tests for the Lock component (stof)
74ad684 
This PR was merged into the 6.3 branch.

Discussion
----------

Fix tests for the Lock component

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | n/a

#50090 was merged with a failing CI (caused by 1 place I forgot to update)

Commits
-------

08cb39e Fix tests for the Lock component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

Assignees
No one assigned
Labels
Lock Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @fabpot @jderusse @carsonbot
0