minor #50097 Fix tests for the Lock component (stof)

fabpot · fabpot · commit 74ad684994fa · 2023-04-21T16:51:29.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- Fix tests for the Lock component | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | n/a #50090 was merged with a failing CI (caused by 1 place I forgot to update) Commits ------- 08cb39e Fix tests for the Lock component
diff --git a/src/Symfony/Component/Lock/Tests/LockFactoryTest.php b/src/Symfony/Component/Lock/Tests/LockFactoryTest.php
@@ -35,8 +35,7 @@ public function testCreateLock()
                 $keys[] = $key;
 
                 return true;
-            }))
-            ->willReturn(true);
+            }));
 
         $logger = $this->createMock(LoggerInterface::class);
         $factory = new LockFactory($store);
@@ -65,8 +64,7 @@ public function testCreateLockFromKey()
                 $keys[] = $key;
 
                 return true;
-            }))
-            ->willReturn(true);
+            }));
 
         $logger = $this->createMock(LoggerInterface::class);
         $factory = new LockFactory($store);
diff --git a/src/Symfony/Component/Lock/Tests/LockTest.php b/src/Symfony/Component/Lock/Tests/LockTest.php
@@ -516,16 +516,14 @@ public function testAcquireTwiceWithExpiration()
             private $keys = [];
             private $initialTtl = 30;
 
-            public function save(Key $key)
+            public function save(Key $key): void
             {
                 $key->reduceLifetime($this->initialTtl);
                 $this->keys[spl_object_hash($key)] = $key;
                 $this->checkNotExpired($key);
-
-                return true;
             }
 
-            public function delete(Key $key)
+            public function delete(Key $key): void
             {
                 unset($this->keys[spl_object_hash($key)]);
             }
@@ -535,7 +533,7 @@ public function exists(Key $key): bool
                 return isset($this->keys[spl_object_hash($key)]);
             }
 
-            public function putOffExpiration(Key $key, $ttl)
+            public function putOffExpiration(Key $key, $ttl): void
             {
                 $key->reduceLifetime($ttl);
                 $this->checkNotExpired($key);

Original file line number	Diff line number	Diff line change
`@@ -516,16 +516,14 @@ public function testAcquireTwiceWithExpiration()`
`516`	`516`	`private $keys = [];`
`517`	`517`	`private $initialTtl = 30;`
`518`	`518`
`519`		`- public function save(Key $key)`
	`519`	`+ public function save(Key $key): void`
`520`	`520`	`{`
`521`	`521`	`$key->reduceLifetime($this->initialTtl);`
`522`	`522`	`$this->keys[spl_object_hash($key)] = $key;`
`523`	`523`	`$this->checkNotExpired($key);`
`524`		`-`
`525`		`- return true;`
`526`	`524`	`}`
`527`	`525`
`528`		`- public function delete(Key $key)`
	`526`	`+ public function delete(Key $key): void`
`529`	`527`	`{`
`530`	`528`	`unset($this->keys[spl_object_hash($key)]);`
`531`	`529`	`}`
`@@ -535,7 +533,7 @@ public function exists(Key $key): bool`
`535`	`533`	`return isset($this->keys[spl_object_hash($key)]);`
`536`	`534`	`}`
`537`	`535`
`538`		`- public function putOffExpiration(Key $key, $ttl)`
	`536`	`+ public function putOffExpiration(Key $key, $ttl): void`
`539`	`537`	`{`
`540`	`538`	`$key->reduceLifetime($ttl);`
`541`	`539`	`$this->checkNotExpired($key);`