8000 minor #50090 [Lock] Add the void return type in Lock interfaces (stof) · symfony/symfony@9289fd8 · GitHub
[go: up one dir, main page]
Skip to content

Commit 9289fd8

Browse files
fabpotfabpot
committed
minor #50090 [Lock] Add the void return type in Lock interfaces (stof)
This PR was merged into the 6.3 branch. Discussion ---------- [Lock] Add the void return type in Lock interfaces | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | n/a Contributes to #47551 Commits ------- c7eab24 Add the void return type in Lock interfaces
2 parents 805f207 + c7eab24 commit 9289fd8

File tree

1 file changed

+72
-0
lines changed

1 file changed

+72
-0
lines changed

‎.github/expected-missing-return-types.diff

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9050,6 +9050,26 @@ index 7e535ebde1..ebb3df9b2b 100644
90509050
+ public function onCheckPassport(CheckPassportEvent $event): void
90519051
{
90529052
$passport = $event->getPassport();
9053+
diff --git a/src/Symfony/Component/Lock/BlockingSharedLockStoreInterface.php b/src/Symfony/Component/Lock/BlockingSharedLockStoreInterface.php
9054+
index 6929206c42..f2494e1061 100644
9055+
--- a/src/Symfony/Component/Lock/BlockingSharedLockStoreInterface.php
9056+
+++ b/src/Symfony/Component/Lock/BlockingSharedLockStoreInterface.php
9057+
@@ -26,4 +26,4 @@ interface BlockingSharedLockStoreInterface extends SharedLockStoreInterface
9058+
* @throws LockConflictedException
9059+
*/
9060+
- public function waitAndSaveRead(Key $key);
9061+
+ public function waitAndSaveRead(Key $key): void;
9062+
}
9063+
diff --git a/src/Symfony/Component/Lock/BlockingStoreInterface.php b/src/Symfony/Component/Lock/BlockingStoreInterface.php
9064+
index 8a84272a8b..e22fac0538 100644
9065+
--- a/src/Symfony/Component/Lock/BlockingStoreInterface.php
9066+
+++ b/src/Symfony/Component/Lock/BlockingStoreInterface.php
9067+
@@ -26,4 +26,4 @@ interface BlockingStoreInterface extends PersistingStoreInterface
9068+
* @throws LockConflictedException
9069+
*/
9070+
- public function waitAndSave(Key $key);
9071+
+ public function waitAndSave(Key $key): void;
9072+
}
90539073
diff --git a/src/Symfony/Component/Lock/LockFactory.php b/src/Symfony/Component/Lock/LockFactory.php
90549074
index 125b6eae50..ac327e8981 100644
90559075
--- a/src/Symfony/Component/Lock/LockFactory.php
@@ -9068,6 +9088,58 @@ index 125b6eae50..ac327e8981 100644
90689088
+ public function createLockFromKey(Key $key, ?float $ttl = 300.0, bool $autoRelease = true): SharedLockInterface
90699089
{
90709090
$lock = new Lock($key, $this->store, $ttl, $autoRelease);
9091+
diff --git a/src/Symfony/Component/Lock/LockInterface.php b/src/Symfony/Component/Lock/LockInterface.php
9092+
index 8ff806497c..991252e453 100644
9093+
--- a/src/Symfony/Component/Lock/LockInterface.php
9094+
+++ b/src/Symfony/Component/Lock/LockInterface.php
9095+
@@ -42, 10000 5 +42,5 @@ interface LockInterface
9096+
* @throws LockAcquiringException If the lock cannot be refreshed
9097+
*/
9098+
- public function refresh(float $ttl = null);
9099+
+ public function refresh(float $ttl = null): void;
9100+
9101+
/**
9102+
@@ -56,5 +56,5 @@ interface LockInterface
9103+
* @throws LockReleasingException If the lock cannot be released
9104+
*/
9105+
- public function release();
9106+
+ public function release(): void;
9107+
9108+
public function isExpired(): bool;
9109+
diff --git a/src/Symfony/Component/Lock/PersistingStoreInterface.php b/src/Symfony/Component/Lock/PersistingStoreInterface.php
9110+
index 10af48c5e6..392446a56a 100644
9111+
--- a/src/Symfony/Component/Lock/PersistingStoreInterface.php
9112+
+++ b/src/Symfony/Component/Lock/PersistingStoreInterface.php
9113+
@@ -29,5 +29,5 @@ interface PersistingStoreInterface
9114+
* @throws LockConflictedException
9115+
*/
9116+
- public function save(Key $key);
9117+
+ public function save(Key $key): void;
9118+
9119+
/**
9120+
@@ -38,5 +38,5 @@ interface PersistingStoreInterface
9121+
* @throws LockReleasingException
9122+
*/
9123+
- public function delete(Key $key);
9124+
+ public function delete(Key $key): void;
9125+
9126+
/**
9127+
@@ -54,4 +54,4 @@ interface PersistingStoreInterface
9128+
* @throws LockConflictedException
9129+
*/
9130+
- public function putOffExpiration(Key $key, float $ttl);
9131+
+ public function putOffExpiration(Key $key, float $ttl): void;
9132+
}
9133+
diff --git a/src/Symfony/Component/Lock/SharedLockStoreInterface.php b/src/Symfony/Component/Lock/SharedLockStoreInterface.php
9134+
index 8246152493..1814a18bca 100644
9135+
--- a/src/Symfony/Component/Lock/SharedLockStoreInterface.php
9136+
+++ b/src/Symfony/Component/Lock/SharedLockStoreInterface.php
9137+
@@ -26,4 +26,4 @@ interface SharedLockStoreInterface extends PersistingStoreInterface
9138+
* @throws LockConflictedException
9139+
*/
9140+
- public function saveRead(Key $key);
9141+
+ public function saveRead(Key $key): void;
9142+
}
90719143
diff --git a/src/Symfony/Component/Lock/Store/CombinedStore.php b/src/Symfony/Component/Lock/Store/CombinedStore.php
90729144
index 9087874c29..5cfd87c4ad 100644
90739145
--- a/src/Symfony/Component/Lock/Store/CombinedStore.php

0 commit comments

Comments
 (0)
0