[VarDumper] Add a caster for the FlattenException #49853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9a6e8c to
9842dc0
Compare
nicolas-grekas
approved these changes
Mar 30, 2023
| public static function castFlattenException(FlattenException $e, array $a, Stub $stub, bool $isNested) | ||
| { | ||
| if ($isNested) { | ||
| $k = sprintf(Caster::PATTERN_PRIVATE, FlattenException::class, 'traceAsString'); |
There was a problem hiding this comment.
updated to benefit from #49852 ;)
| @@ -354,4 +355,33 @@ public function testAnonymous() | |||
|
|
|||
| $this->assertDumpMatchesFormat($expectedDump, $e, Caster::EXCLUDE_VERBOSE); | |||
| } | |||
|
|
|||
| /** | |||
| * @requires function \Symfony\Component\ErrorHandler\Exception\FlattenException::create | |||
8000
There was a problem hiding this comment.
Oh! Nice. I check for requires class but it didn't exist. Nice usage of "function"
|
Thank you @lyrixx. |
chalasr
added a commit
that referenced
this pull request
Apr 5, 2023
This PR was merged into the 6.3 branch. Discussion ---------- Fix the test for casting FlattenException on Windows | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a The assertion should avoid forcing to show path separators, as done in other tests of the caster, as path separators are different on Windows. This fixes the test introduced in #49853 Commits ------- 1464e1e Fix the test for casting FlattenException on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information is duplicated, and when debuging messenger errors, the output is way too verbose.
This PR enchance the situation.