[VarDumper] Add Caster::PATTERN_PRIVATE to help builing key #49852
Conversation
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR | not needed I guess |
|
Thank you @lyrixx. |
|
should it be a constant containing a sprintf pattern or a static method taking the class name ? With the sprintf pattern, I fear devs will do mistakes by trying to use the constant only, as other constants. |
|
I prefer the static method too. But I asked to @nicolas-grekas on slack and he told me to do that. Anyway I'm up to add a method! |
|
I'm not in favor of adding a method for this. My preference is that ppl know the pattern and use strings directly. I'm fine with adding a constants if that helps. But a method is the beginning of an API, and I don't think we should add an API for concatenating these strings. |
|
To me, this constant does not help because it does not remove the need to know the pattern to understand how to use it. |
|
It does help, eg to use |